-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Open
Labels
status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triagedtype: bugA general bugA general bug
Description
Describe the bug
Upgrading from 6.x to 7.0, the org.springframework.security.provisioning package has now been @NullMarked.
Both getPassword and setPassword in MutableUser have been marked as @Nullable, but changePassword in UserDetailsManager has not.
There are situations where you would want to change a password without having the old one (e.g. forgot password resets and admin changes), which naturally involved passing null as the oldPassword. However, any code that implemented this now generates analysis errors due to the implicit @NonNull.
Please add @Nullable to at least oldPassword, and possibly newPassword as well for consistency with MutableUserDetails.
Metadata
Metadata
Assignees
Labels
status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triagedtype: bugA general bugA general bug