Skip to content

Fail Release Workflows if Job Fails #16764

Open
@rwinch

Description

@rwinch

Currently if a step in the release process fails, it still appears to pass the build. For example, this build of Update Scheduled Release Version appeared to succeed.

Image

However, if you click into the details the Check Release Due Date step failed.

Run echo "result=$(./gradlew -q checkMilestoneIsDueToday -PnextVersion=$VERSION -PgitHubAccessToken=$TOKEN)" >> $GITHUB_OUTPUT
Error during JavaScript execution
com.gargoylesoftware.htmlunit.ScriptException: missing formal parameter (https://www.sonarsource.com/app-6198c9e3d749c634c431.js#2)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$HtmlUnitContextAction.run(JavaScriptEngine.java:1001)
	at net.sourceforge.htmlunit.corejs.javascript.Context.call(Context.java:590)
	at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.call(ContextFactory.java:484)
	at com.gargoylesoftware.htmlunit.javascript.HtmlUnitContextFactory.callSecured(HtmlUnitContextFactory.java:349)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.compile(JavaScriptEngine.java:830)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.compile(JavaScriptEngine.java:796)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.compile(JavaScriptEngine.java:118)
	at com.gargoylesoftware.htmlunit.html.HtmlPage.loadJavaScriptFromUrl(HtmlPage.java:1153)
	at com.gargoylesoftware.htmlunit.html.HtmlPage.loadExternalJavaScriptFile(HtmlPage.java:1024)
	at com.gargoylesoftware.htmlunit.html.ScriptElementSupport.executeScriptIfNeeded(ScriptElementSupport.java:196)
	at com.gargoylesoftware.htmlunit.html.ScriptElementSupport$1.execute(ScriptElementSupport.java:120)
	at com.gargoylesoftware.htmlunit.html.HtmlPage.initialize(HtmlPage.java:342)
	at com.gargoylesoftware.htmlunit.WebClient.loadWebResponseInto(WebClient.java:689)
	at com.gargoylesoftware.htmlunit.WebClient.loadWebResponseInto(WebClient.java:571)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:489)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:396)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:534)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:516)
	at s101.S101PluginExtension.<init>(S101PluginExtension.java:120)
	at s101.S101Plugin.apply(S101Plugin.java:37)
	at s101.S101Plugin.apply(S101Plugin.java:34)
	at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:54)
	at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:51)
	at org.gradle.api.internal.plugins.ModelDefaultsApplyingPluginTarget.applyImperative(ModelDefaultsApplyingPluginTarget.java:46)
	at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:190)
	at org.gradle.api.internal.plugins.DefaultPluginManager.access$100(DefaultPluginManager.java:54)
	at org.gradle.api.internal.plugins.DefaultPluginManager$AddPluginBuildOperation.run(DefaultPluginManager.java:288)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.shiftExpr(Parser.java:2486)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.relExpr(Parser.java:2464)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.eqExpr(Parser.java:2440)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.bitAndExpr(Parser.java:2431)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.bitXorExpr(Parser.java:2422)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.bitOrExpr(Parser.java:2413)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.andExpr(Parser.java:2404)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.orExpr(Parser.java:2395)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.condExpr(Parser.java:2362)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.assignExpr(Parser.java:2320)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.expr(Parser.java:2303)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.statementHelper(Parser.java:1249)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.statement(Parser.java:1104)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.parse(Parser.java:632)
	at net.sourceforge.htmlunit.corejs.javascript.Parser.parse(Parser.java:562)
	at net.sourceforge.htmlunit.corejs.javascript.Context.parse(Context.java:2549)
	at net.sourceforge.htmlunit.corejs.javascript.Context.compileImpl(Context.java:2480)
	at net.sourceforge.htmlunit.corejs.javascript.Context.compileString(Context.java:1448)
	at com.gargoylesoftware.htmlunit.javascript.HtmlUnitContextFactory$TimeoutContext.compileString(HtmlUnitContextFactory.java:221)
	at net.sourceforge.htmlunit.corejs.javascript.Context.compileString(Context.java:1436)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$1.doRun(JavaScriptEngine.java:821)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$HtmlUnitContextAction.run(JavaScriptEngine.java:984)
	... 205 more

FAILURE: Build failed with an exception.

* Where:
Build file '/home/runner/work/spring-security-commercial/spring-security-commercial/build.gradle' line: 23

* What went wrong:
A problem occurred evaluating root project 'spring-security-commercial'.
> Failed to apply plugin 's101'.
   > java.lang.RuntimeException: com.gargoylesoftware.htmlunit.ScriptException: missing formal parameter (https://www.sonarsource.com/app-6198c9e3d749c634c431.js#2)

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

BUILD FAILED in 3s

The workflow should have failed since the Job failed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in: buildAn issue in the buildtheme: build-automationBuild enhancements and reusability for automating releases, sending notifications, etc.type: bugA general bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions