Skip to content

Commit ff1070d

Browse files
committed
remove redundant modifiers found by checkstyle
1 parent d9016e5 commit ff1070d

File tree

124 files changed

+187
-190
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

124 files changed

+187
-190
lines changed

acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,14 @@ class AclClassIdUtils {
4141

4242
private ConversionService conversionService;
4343

44-
public AclClassIdUtils() {
44+
AclClassIdUtils() {
4545
GenericConversionService genericConversionService = new GenericConversionService();
4646
genericConversionService.addConverter(String.class, Long.class, new StringToLongConverter());
4747
genericConversionService.addConverter(String.class, UUID.class, new StringToUUIDConverter());
4848
this.conversionService = genericConversionService;
4949
}
5050

51-
public AclClassIdUtils(ConversionService conversionService) {
51+
AclClassIdUtils(ConversionService conversionService) {
5252
Assert.notNull(conversionService, "conversionService must not be null");
5353
this.conversionService = conversionService;
5454
}

acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ private class ProcessResultSet implements ResultSetExtractor<Set<Long>> {
559559
private final Map<Serializable, Acl> acls;
560560
private final List<Sid> sids;
561561

562-
public ProcessResultSet(Map<Serializable, Acl> acls, List<Sid> sids) {
562+
ProcessResultSet(Map<Serializable, Acl> acls, List<Sid> sids) {
563563
Assert.notNull(acls, "ACLs cannot be null");
564564
this.acls = acls;
565565
this.sids = sids; // can be null
@@ -683,7 +683,7 @@ private void convertCurrentResultIntoObject(Map<Serializable, Acl> acls,
683683
private static class StubAclParent implements Acl {
684684
private final Long id;
685685

686-
public StubAclParent(Long id) {
686+
StubAclParent(Long id) {
687687
this.id = id;
688688
}
689689

cas/src/main/java/org/springframework/security/cas/jackson2/AssertionImplMixin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ class AssertionImplMixin {
5555
* @param attributes the key/value pairs for this attribute.
5656
*/
5757
@JsonCreator
58-
public AssertionImplMixin(@JsonProperty("principal") AttributePrincipal principal,
58+
AssertionImplMixin(@JsonProperty("principal") AttributePrincipal principal,
5959
@JsonProperty("validFromDate") Date validFromDate, @JsonProperty("validUntilDate") Date validUntilDate,
6060
@JsonProperty("authenticationDate") Date authenticationDate, @JsonProperty("attributes") Map<String, Object> attributes){
6161
}
62-
}
62+
}

cas/src/main/java/org/springframework/security/cas/jackson2/AttributePrincipalImplMixin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ class AttributePrincipalImplMixin {
5151
* @param proxyRetriever the ProxyRetriever implementation to call back to the CAS server.
5252
*/
5353
@JsonCreator
54-
public AttributePrincipalImplMixin(@JsonProperty("name") String name, @JsonProperty("attributes") Map<String, Object> attributes,
54+
AttributePrincipalImplMixin(@JsonProperty("name") String name, @JsonProperty("attributes") Map<String, Object> attributes,
5555
@JsonProperty("proxyGrantingTicket") String proxyGrantingTicket,
5656
@JsonProperty("proxyRetriever") ProxyRetriever proxyRetriever) {
5757
}
58-
}
58+
}

cas/src/main/java/org/springframework/security/cas/jackson2/CasAuthenticationTokenMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class CasAuthenticationTokenMixin {
6969
* principal and how to obtain a proxy ticket for the user.
7070
*/
7171
@JsonCreator
72-
public CasAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal,
72+
CasAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal,
7373
@JsonProperty("credentials") Object credentials,
7474
@JsonProperty("authorities") Collection<? extends GrantedAuthority> authorities,
7575
@JsonProperty("userDetails") UserDetails userDetails, @JsonProperty("assertion") Assertion assertion) {

cas/src/main/java/org/springframework/security/cas/web/CasAuthenticationFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ private boolean proxyReceptorConfigured() {
415415
private class CasAuthenticationFailureHandler implements AuthenticationFailureHandler {
416416
private final AuthenticationFailureHandler serviceTicketFailureHandler;
417417

418-
public CasAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) {
418+
CasAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) {
419419
Assert.notNull(failureHandler, "failureHandler");
420420
this.serviceTicketFailureHandler = failureHandler;
421421
}
@@ -432,4 +432,4 @@ public void onAuthenticationFailure(HttpServletRequest request,
432432
}
433433
}
434434
}
435-
}
435+
}

cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ public void removeTicketFromCache(String serviceTicket) {
414414
private class MockTicketValidator implements TicketValidator {
415415
private boolean returnTicket;
416416

417-
public MockTicketValidator(boolean returnTicket) {
417+
MockTicketValidator(boolean returnTicket) {
418418
this.returnTicket = returnTicket;
419419
}
420420

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ private static class EnableGlobalAuthenticationAutowiredConfigurer extends
193193
private static final Log logger = LogFactory
194194
.getLog(EnableGlobalAuthenticationAutowiredConfigurer.class);
195195

196-
public EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) {
196+
EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) {
197197
this.context = context;
198198
}
199199

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class InitializeAuthenticationProviderBeanManagerConfigurer
4242
/**
4343
* @param context the ApplicationContext to look up beans.
4444
*/
45-
public InitializeAuthenticationProviderBeanManagerConfigurer(
45+
InitializeAuthenticationProviderBeanManagerConfigurer(
4646
ApplicationContext context) {
4747
this.context = context;
4848
}
@@ -83,4 +83,4 @@ private <T> T getBeanOrNull(Class<T> type) {
8383
.getBean(userDetailsBeanNames[0], type);
8484
}
8585
}
86-
}
86+
}

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class InitializeUserDetailsBeanManagerConfigurer
4343
/**
4444
* @param context
4545
*/
46-
public InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) {
46+
InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) {
4747
this.context = context;
4848
}
4949

0 commit comments

Comments
 (0)