Skip to content

Commit fd3efb7

Browse files
garyrussellartembilan
authored andcommitted
Fix Package Tangle
The introduction of `KafkaStreamsConfiguration` introduced a tangle between `core` and `config`. Move the `StreamsBuilderFactoryBean` to `config`. * Polishing - PR Comments
1 parent 7fdc441 commit fd3efb7

10 files changed

+13
-12
lines changed

spring-kafka/src/main/java/org/springframework/kafka/annotation/EnableKafkaStreams.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import java.lang.annotation.Target;
2424

2525
import org.springframework.context.annotation.Import;
26-
import org.springframework.kafka.core.StreamsBuilderFactoryBean;
26+
import org.springframework.kafka.config.StreamsBuilderFactoryBean;
2727

2828
/**
2929
* Enable default Kafka Streams components. To be used on

spring-kafka/src/main/java/org/springframework/kafka/annotation/KafkaStreamsDefaultConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import org.springframework.context.annotation.Bean;
2525
import org.springframework.context.annotation.Configuration;
2626
import org.springframework.kafka.config.KafkaStreamsConfiguration;
27-
import org.springframework.kafka.core.StreamsBuilderFactoryBean;
27+
import org.springframework.kafka.config.StreamsBuilderFactoryBean;
2828

2929
/**
3030
* {@code @Configuration} class that registers a {@link StreamsBuilderFactoryBean}

spring-kafka/src/main/java/org/springframework/kafka/core/CompositeKafkaStreamsCustomizer.java renamed to spring-kafka/src/main/java/org/springframework/kafka/config/CompositeKafkaStreamsCustomizer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.core;
17+
package org.springframework.kafka.config;
1818

1919
import java.util.ArrayList;
2020
import java.util.List;

spring-kafka/src/main/java/org/springframework/kafka/core/KafkaStreamsCustomizer.java renamed to spring-kafka/src/main/java/org/springframework/kafka/config/KafkaStreamsCustomizer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.core;
17+
package org.springframework.kafka.config;
1818

1919
import org.apache.kafka.streams.KafkaStreams;
2020

spring-kafka/src/main/java/org/springframework/kafka/core/StreamsBuilderFactoryBean.java renamed to spring-kafka/src/main/java/org/springframework/kafka/config/StreamsBuilderFactoryBean.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.core;
17+
package org.springframework.kafka.config;
1818

1919
import java.util.Map;
2020
import java.util.Properties;
@@ -31,7 +31,7 @@
3131
import org.springframework.beans.factory.config.AbstractFactoryBean;
3232
import org.springframework.context.SmartLifecycle;
3333
import org.springframework.kafka.KafkaException;
34-
import org.springframework.kafka.config.KafkaStreamsConfiguration;
34+
import org.springframework.kafka.core.CleanupConfig;
3535
import org.springframework.lang.Nullable;
3636
import org.springframework.util.Assert;
3737

spring-kafka/src/test/java/org/springframework/kafka/core/KafkaStreamsCustomizerTests.java renamed to spring-kafka/src/test/java/org/springframework/kafka/config/KafkaStreamsCustomizerTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.core;
17+
package org.springframework.kafka.config;
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
2020

@@ -32,7 +32,6 @@
3232
import org.springframework.kafka.annotation.EnableKafka;
3333
import org.springframework.kafka.annotation.EnableKafkaStreams;
3434
import org.springframework.kafka.annotation.KafkaStreamsDefaultConfiguration;
35-
import org.springframework.kafka.config.KafkaStreamsConfiguration;
3635
import org.springframework.kafka.test.EmbeddedKafkaBroker;
3736
import org.springframework.kafka.test.context.EmbeddedKafka;
3837
import org.springframework.test.annotation.DirtiesContext;

spring-kafka/src/test/java/org/springframework/kafka/core/StreamsBuilderFactoryBeanTests.java renamed to spring-kafka/src/test/java/org/springframework/kafka/config/StreamsBuilderFactoryBeanTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.core;
17+
package org.springframework.kafka.config;
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
2020

@@ -37,7 +37,7 @@
3737
import org.springframework.context.annotation.Configuration;
3838
import org.springframework.kafka.annotation.EnableKafkaStreams;
3939
import org.springframework.kafka.annotation.KafkaStreamsDefaultConfiguration;
40-
import org.springframework.kafka.config.KafkaStreamsConfiguration;
40+
import org.springframework.kafka.core.CleanupConfig;
4141
import org.springframework.kafka.test.EmbeddedKafkaBroker;
4242
import org.springframework.kafka.test.context.EmbeddedKafka;
4343
import org.springframework.test.annotation.DirtiesContext;

spring-kafka/src/test/java/org/springframework/kafka/core/StreamsBuilderFactoryLateConfigTests.java renamed to spring-kafka/src/test/java/org/springframework/kafka/config/StreamsBuilderFactoryLateConfigTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.core;
17+
package org.springframework.kafka.config;
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
2020

spring-kafka/src/test/java/org/springframework/kafka/kstream/KafkaStreamsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,12 @@
5454
import org.springframework.kafka.config.ConcurrentKafkaListenerContainerFactory;
5555
import org.springframework.kafka.config.KafkaListenerContainerFactory;
5656
import org.springframework.kafka.config.KafkaStreamsConfiguration;
57+
import org.springframework.kafka.config.StreamsBuilderFactoryBean;
5758
import org.springframework.kafka.core.ConsumerFactory;
5859
import org.springframework.kafka.core.DefaultKafkaConsumerFactory;
5960
import org.springframework.kafka.core.DefaultKafkaProducerFactory;
6061
import org.springframework.kafka.core.KafkaTemplate;
6162
import org.springframework.kafka.core.ProducerFactory;
62-
import org.springframework.kafka.core.StreamsBuilderFactoryBean;
6363
import org.springframework.kafka.listener.ConcurrentMessageListenerContainer;
6464
import org.springframework.kafka.support.serializer.JsonSerde;
6565
import org.springframework.kafka.test.EmbeddedKafkaBroker;

src/reference/asciidoc/whats-new.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ See <<serdes>> for more information.
7878

7979
The streams configuration bean must now be a simple `Properties` object instead of a `StreamsConfig`.
8080

81+
The `StreamsBuilderFactoryBean` has been moved from package `...core` to `...config`.
82+
8183
See <<kafka-streams>> for more information.
8284

8385

0 commit comments

Comments
 (0)