Skip to content

Commit 482b546

Browse files
garyrussellartembilan
authored andcommitted
GH-1637: Fix TopicPartitionOffset.hashCode()
Resolves #1637 **cherry-pick to 2.5.x, 2.4.x, 2.3.x** (cherry picked from commit e666153)
1 parent 9a013e2 commit 482b546

File tree

2 files changed

+39
-1
lines changed

2 files changed

+39
-1
lines changed

spring-kafka/src/main/java/org/springframework/kafka/support/TopicPartitionOffset.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ public boolean equals(Object o) {
212212

213213
@Override
214214
public int hashCode() {
215-
return this.topicPartition.hashCode();
215+
return this.topicPartition.hashCode() + this.position.hashCode();
216216
}
217217

218218
@Override
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
/*
2+
* Copyright 2020 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package org.springframework.kafka.support;
18+
19+
import static org.assertj.core.api.Assertions.assertThat;
20+
21+
import org.junit.jupiter.api.Test;
22+
23+
import org.springframework.kafka.support.TopicPartitionOffset.SeekPosition;
24+
25+
/**
26+
* @author Gary Russell
27+
* @since 2.3.13
28+
*
29+
*/
30+
public class TopicPartitionOffsetTests {
31+
32+
@Test
33+
void hashCodeTest() {
34+
assertThat(new TopicPartitionOffset("foo", 1, SeekPosition.BEGINNING).hashCode())
35+
.isNotEqualTo(new TopicPartitionOffset("foo", 1, SeekPosition.END).hashCode());
36+
}
37+
38+
}

0 commit comments

Comments
 (0)