-
Notifications
You must be signed in to change notification settings - Fork 38.6k
Open
Labels
status: blockedAn issue that's blocked on an external project changeAn issue that's blocked on an external project changetheme: observabilityAn issue related to observability and tracingAn issue related to observability and tracingtype: documentationA documentation taskA documentation task
Milestone
Description
To me http_server_requests_active_seconds
seems to be completly undocumented, so it would be nice to document that metric somewhere.
I also think that all of these metrics should have a help text on prometheus. At least that is where I rely on usually and I do not see a reason why not to have it.
Metadata
Metadata
Assignees
Labels
status: blockedAn issue that's blocked on an external project changeAn issue that's blocked on an external project changetheme: observabilityAn issue related to observability and tracingAn issue related to observability and tracingtype: documentationA documentation taskA documentation task
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
bclozel commentedon Jun 4, 2025
I'm not sure we should document that at the Spring Framework level, because I think it ultimately depends on the Micrometer configuration directly. I believe this is a long task timer automatically configured with micrometer observations, but this can be disabled. Maybe we should point to some Micrometer Observation reference documentation for that, but I couldn't find a particular section.
As for the "prometheus help text", are you referring to the description field for metrics? If so, this is not supported directly at the moment by Micrometer.
Pinging @shakuzen @jonatan-ivanov to get their opinion.
david0 commentedon Jun 4, 2025
Yes, in micrometer terminology its description.
I see its not easy and also micrometer needs to be changed, still I think it should be done somehow.
Besides that, I think it really should be in the Spring Reference documentation. Even if its just implicitly brought in with micrometer, I assume its what most people have and also what a lot of people are interested in to understand.
jonatan-ivanov commentedon Jun 4, 2025
Please see this comment on the issue that Brian linked: micrometer-metrics/micrometer#5478 (comment).
TL;DR: it is only used for metrics, there are not a lot of backends that support it, and other than this issue we only saw one request for this functionality. The disadvantage is adding an extra reference to the
Observation.Context
(performance).I think it would be nice to have it, although I don't know any use-case for this other than Prometheus on top of my hear right now. Maybe we could use this in docs-gen when we generate documentation for Observations?
In order to document this, there are a few things we need to consider:
http.server.requests
andhttp.server.requests.active
. Would that help?DefaultMeterObservationHandler
and describe what metrics it will create and reference that from the framework docs?shakuzen commentedon Jun 5, 2025
I've opened micrometer-metrics/micrometer#6361 for that.
[-]Document http_server_requests_active_seconds[/-][+]Link observability section to Micrometer Observation Handler docs[/+]bclozel commentedon Jun 5, 2025
Thanks team!
I've repurposed this issue. We will link to this new doc when it's live.