Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap disconnected client exceptions as AsyncRequestNotUsableException in Servlet container onError callback #34363

Closed
rstoyanchev opened this issue Feb 4, 2025 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

We raise this in StandardServletAsyncWebRequest when wrapped response I/O methods catch an IOException. However, the Servlet container may be first in reporting the same via AsyncListener#onError in which case @ExceptionHandler methods see the raw IOException making it more difficult to differentiate from any other I/O error.

We should also apply the AsyncRequestNotUsableException wrapper in WebAsyncManager, in onError handling for exceptions recognized with DisconnectedClientHelper.

Originally reported in #34005.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Feb 4, 2025
@rstoyanchev rstoyanchev added this to the 6.2.3 milestone Feb 4, 2025
@rstoyanchev rstoyanchev self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant