Skip to content

Add CBOR codec (single value only) #22767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdeleuze opened this issue Apr 8, 2019 · 2 comments
Closed

Add CBOR codec (single value only) #22767

sdeleuze opened this issue Apr 8, 2019 · 2 comments
Assignees
@sdeleuze
Labels
in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.2 M2

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Apr 8, 2019

It seems RSocket only requires single value support for codecs, which mean we probably could add CBOR codec with only that scope and add such support to RSocket, and even configure it by default in Boot since that's a popular binary format that does not require code generation from a schema.

Related to #20513 which targets full support and configuration for WebFlux.
@sdeleuze sdeleuze added the type: enhancement A general enhancement label Apr 8, 2019
@sdeleuze sdeleuze added this to the 5.2 M1 milestone Apr 8, 2019
@sdeleuze sdeleuze self-assigned this Apr 8, 2019
@sdeleuze sdeleuze modified the milestones: 5.2 M1, 5.2 M2 Apr 9, 2019
@rstoyanchev
Copy link
Contributor

I've created #22782 that I think should be done first.

@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) labels Apr 10, 2019
@rstoyanchev
Copy link
Contributor

I've added methods to Encoder and Decoder for encoding/decoding single value and DataBuffer, so give this here a go with those changes.

@bclozel bclozel mentioned this issue May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M2
Development

No branches or pull requests
2 participants
@sdeleuze @rstoyanchev