Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise generic type handling in GsonHttpMessageConverter [SPR-15381] #19944

Closed
spring-projects-issues opened this issue Mar 26, 2017 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Mar 26, 2017

Juergen Hoeller opened SPR-15381 and commented

In the course of #19490, it turns out that GsonHttpMessageConverter should be sharing AbstractJackson2HttpMessageConverter's recently revised generic type handling, also shared by the new JsonbHttpMessageConverter.

The full extent of this is only really feasible in 5.0, but in particular deprecations of getTypeToken and co should be backported to 4.3.8 as well.


Issue Links:

Referenced from: commits 3c8fc46, e5fdd4c

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

There's also the same generic type resolution algorithm in Jackson2CodecSupport in our new reactive codec abstraction. This needs to be unified and reused as far as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants