Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter annotations such as @RequestParam not applied from an interface [SPR-7567] #12224

Closed
spring-projects-issues opened this issue Sep 17, 2010 · 6 comments
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: bulk-closed An outdated, unresolved issue that's closed in bulk as part of a cleaning process

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Sep 17, 2010

Richard Larson opened SPR-7567 and commented


public interface ListableController<Model> {
	
	@ModelAttribute("results")
	@RequestMapping(method = RequestMethod.GET)
	public List<Model> index(
			@RequestParam(defaultValue = "1") Integer page);

}
//Page should be equal to one but is not.
public class Foo implements ListableController<Person> {
	public List<Person> index(Integer page) {
		System.out.println(page + " should be equal to one but is not.");
		return new ArrayList<Person>();
	}
}

May possibly be related to #11985.


Affects: 3.0.4

Attachments:

Issue Links:

2 votes, 7 watchers

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 17, 2010

Juergen Hoeller commented

This might be related to #12141, and might possibly be fixed along with that one already. So it would be great if you could give a recent 3.0.5 snapshot a try...

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Richard Larson commented

I just tried it with 3.0.5.BUILD-SNAPSHOT and it did not work...

@spring-projects-issues
Copy link
Collaborator Author

Andrew Muraco commented

Possible way to enhance MethodParameter to fall back to searching the interfaces for parameter annotations. It might have other side effects though.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Closing groups of outdated issues. Please reopen if still relevant.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 1, 2016

Darya commented

Still doesn't work (at least @RequestParam(value = "...")). Possibly related to #15682

@spring-projects-issues spring-projects-issues added status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues removed the type: enhancement A general enhancement label Jan 11, 2019
@rstoyanchev rstoyanchev added status: bulk-closed An outdated, unresolved issue that's closed in bulk as part of a cleaning process and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 11, 2019
@spring-projects-issues
Copy link
Collaborator Author

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: bulk-closed An outdated, unresolved issue that's closed in bulk as part of a cleaning process
Projects
None yet
Development

No branches or pull requests

2 participants