Skip to content

Commit c634702

Browse files
committed
Merge branch '6.1.x'
# Conflicts: # spring-webmvc/src/test/java/org/springframework/web/servlet/config/annotation/ViewResolutionIntegrationTests.java
2 parents 8918a77 + 7322a0d commit c634702

File tree

3 files changed

+27
-24
lines changed

3 files changed

+27
-24
lines changed

framework-platform/framework-platform.gradle

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ dependencies {
1313
api(platform("io.netty:netty5-bom:5.0.0.Alpha5"))
1414
api(platform("io.projectreactor:reactor-bom:2024.0.0-M3"))
1515
api(platform("io.rsocket:rsocket-bom:1.1.3"))
16-
api(platform("org.apache.groovy:groovy-bom:4.0.21"))
16+
api(platform("org.apache.groovy:groovy-bom:4.0.22"))
1717
api(platform("org.apache.logging.log4j:log4j-bom:2.21.1"))
1818
api(platform("org.assertj:assertj-bom:3.26.0"))
1919
api(platform("org.eclipse.jetty:jetty-bom:12.0.11"))
@@ -55,9 +55,9 @@ dependencies {
5555
api("io.r2dbc:r2dbc-spi:1.0.0.RELEASE")
5656
api("io.reactivex.rxjava3:rxjava:3.1.8")
5757
api("io.smallrye.reactive:mutiny:1.10.0")
58-
api("io.undertow:undertow-core:2.3.13.Final")
59-
api("io.undertow:undertow-servlet:2.3.13.Final")
60-
api("io.undertow:undertow-websockets-jsr:2.3.13.Final")
58+
api("io.undertow:undertow-core:2.3.14.Final")
59+
api("io.undertow:undertow-servlet:2.3.14.Final")
60+
api("io.undertow:undertow-websockets-jsr:2.3.14.Final")
6161
api("io.vavr:vavr:0.10.4")
6262
api("jakarta.activation:jakarta.activation-api:2.0.1")
6363
api("jakarta.annotation:jakarta.annotation-api:2.0.0")
@@ -100,12 +100,12 @@ dependencies {
100100
api("org.apache.derby:derbyclient:10.16.1.1")
101101
api("org.apache.derby:derbytools:10.16.1.1")
102102
api("org.apache.httpcomponents.client5:httpclient5:5.3.1")
103-
api("org.apache.httpcomponents.core5:httpcore5-reactive:5.2.4")
103+
api("org.apache.httpcomponents.core5:httpcore5-reactive:5.2.5")
104104
api("org.apache.poi:poi-ooxml:5.2.5")
105-
api("org.apache.tomcat.embed:tomcat-embed-core:10.1.24")
106-
api("org.apache.tomcat.embed:tomcat-embed-websocket:10.1.24")
107-
api("org.apache.tomcat:tomcat-util:10.1.24")
108-
api("org.apache.tomcat:tomcat-websocket:10.1.24")
105+
api("org.apache.tomcat.embed:tomcat-embed-core:10.1.25")
106+
api("org.apache.tomcat.embed:tomcat-embed-websocket:10.1.25")
107+
api("org.apache.tomcat:tomcat-util:10.1.25")
108+
api("org.apache.tomcat:tomcat-websocket:10.1.25")
109109
api("org.aspectj:aspectjrt:1.9.22.1")
110110
api("org.aspectj:aspectjtools:1.9.22.1")
111111
api("org.aspectj:aspectjweaver:1.9.22.1")
@@ -114,7 +114,7 @@ dependencies {
114114
api("org.codehaus.jettison:jettison:1.5.4")
115115
api("org.crac:crac:1.4.0")
116116
api("org.dom4j:dom4j:2.1.4")
117-
api("org.eclipse.jetty:jetty-reactive-httpclient:4.0.4")
117+
api("org.eclipse.jetty:jetty-reactive-httpclient:4.0.5")
118118
api("org.eclipse.persistence:org.eclipse.persistence.jpa:3.0.4")
119119
api("org.eclipse:yasson:2.0.4")
120120
api("org.ehcache:ehcache:3.10.8")

spring-webflux/src/test/java/org/springframework/web/reactive/config/WebFluxViewResolutionIntegrationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ class FreeMarkerTests {
7878
@Test
7979
void freemarkerWithInvalidConfig() {
8080
assertThatRuntimeException()
81-
.isThrownBy(() -> runTest(InvalidFreeMarkerWebFluxConfig.class))
82-
.withMessageContaining("In addition to a FreeMarker view resolver ");
81+
.isThrownBy(() -> runTest(InvalidFreeMarkerWebFluxConfig.class))
82+
.withMessageContaining("In addition to a FreeMarker view resolver ");
8383
}
8484

8585
@Test

spring-webmvc/src/test/java/org/springframework/web/servlet/config/annotation/ViewResolutionIntegrationTests.java

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package org.springframework.web.servlet.config.annotation;
1818

19-
import org.junit.jupiter.api.BeforeAll;
2019
import org.junit.jupiter.api.Nested;
2120
import org.junit.jupiter.api.Test;
2221

@@ -48,10 +47,7 @@
4847
*/
4948
class ViewResolutionIntegrationTests {
5049

51-
@BeforeAll
52-
static void verifyDefaultFileEncoding() {
53-
assertThat(System.getProperty("file.encoding")).as("JVM default file encoding").isEqualTo("UTF-8");
54-
}
50+
private static final boolean utf8Default = UTF_8.name().equals(System.getProperty("file.encoding"));
5551

5652

5753
@Nested
@@ -71,22 +67,26 @@ class FreeMarkerTests {
7167
@Test
7268
void freemarkerWithInvalidConfig() {
7369
assertThatRuntimeException()
74-
.isThrownBy(() -> runTest(InvalidFreeMarkerWebConfig.class))
75-
.withMessageContaining("In addition to a FreeMarker view resolver ");
70+
.isThrownBy(() -> runTest(InvalidFreeMarkerWebConfig.class))
71+
.withMessageContaining("In addition to a FreeMarker view resolver ");
7672
}
7773

7874
@Test
7975
void freemarkerWithDefaultEncoding() throws Exception {
8076
// Since no explicit encoding or content type has been set, we expect ISO-8859-1,
8177
// which is the default.
82-
runTestAndAssertResults(DEFAULT_ENCODING, FreeMarkerDefaultEncodingConfig.class);
78+
if (utf8Default) {
79+
runTestAndAssertResults(DEFAULT_ENCODING, FreeMarkerDefaultEncodingConfig.class);
80+
}
8381
}
8482

8583
@Test // gh-16629, gh-33071
8684
void freemarkerWithExistingViewResolverWithDefaultEncoding() throws Exception {
8785
// Since no explicit encoding or content type has been set, we expect ISO-8859-1,
8886
// which is the default.
89-
runTestAndAssertResults(DEFAULT_ENCODING, ExistingViewResolverConfig.class);
87+
if (utf8Default) {
88+
runTestAndAssertResults(DEFAULT_ENCODING, ExistingViewResolverConfig.class);
89+
}
9090
}
9191

9292
@Test // gh-33071, gh-33119
@@ -190,20 +190,23 @@ public FreeMarkerConfigurer freeMarkerConfigurer() {
190190
}
191191
}
192192

193+
193194
@Nested
194195
class GroovyMarkupTests {
195196

196197
@Test
197198
void groovyMarkupInvalidConfig() {
198199
assertThatRuntimeException()
199-
.isThrownBy(() -> runTest(InvalidGroovyMarkupWebConfig.class))
200-
.withMessageContaining("In addition to a Groovy markup view resolver ");
200+
.isThrownBy(() -> runTest(InvalidGroovyMarkupWebConfig.class))
201+
.withMessageContaining("In addition to a Groovy markup view resolver ");
201202
}
202203

203204
@Test
204205
void groovyMarkup() throws Exception {
205206
MockHttpServletResponse response = runTest(GroovyMarkupWebConfig.class);
206-
assertThat(response.getContentAsString()).isEqualTo("<html><body>Hello, Java Café</body></html>");
207+
if (utf8Default) {
208+
assertThat(response.getContentAsString()).isEqualTo("<html><body>Hello, Java Café</body></html>");
209+
}
207210
}
208211

209212

0 commit comments

Comments
 (0)