simplify try with resource

Signed-off-by: Vincent Potucek <[email protected]>

Author: Vincent Potucek

spring-web/src/test/java/org/springframework/http/converter/ResourceRegionHttpMessageConverterTests.java

@@ -17,6 +17,7 @@
 package org.springframework.http.converter;
 
 import java.io.ByteArrayInputStream;
+import java.io.IOException;
 import java.lang.reflect.Type;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
@@ -27,6 +28,7 @@
 
 import org.springframework.core.ParameterizedTypeReference;
 import org.springframework.core.io.ClassPathResource;
+import org.springframework.core.io.InputStreamResource;
 import org.springframework.core.io.Resource;
 import org.springframework.core.io.support.ResourceRegion;
 import org.springframework.http.HttpHeaders;
@@ -36,6 +38,7 @@
 import org.springframework.web.testfixture.http.MockHttpOutputMessage;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
 import static org.mockito.BDDMockito.given;
 import static org.mockito.Mockito.mock;
 
@@ -198,4 +201,86 @@ public void applicationOctetStreamDefaultContentType() throws Exception {
 		assertThat(outputMessage.getBodyAsString(StandardCharsets.UTF_8)).isEqualTo("Spring");
 	}
 
+	@Test
+	void shouldNotWriteForUnsupportedType() throws Exception {
+		MockHttpOutputMessage outputMessage = new MockHttpOutputMessage();
+		Object unsupportedBody = new Object();
+
+		assertThatThrownBy(() -> converter.write(unsupportedBody, null, outputMessage))
+				.isInstanceOf(HttpMessageNotWritableException.class);
+	}
+
+	@Test
+	void shouldHandleEmptyResourceRegionCollection() throws Exception {
+		MockHttpOutputMessage outputMessage = new MockHttpOutputMessage();
+		List<ResourceRegion> emptyRegions = Collections.emptyList();
+
+		assertThatThrownBy(() -> converter.write(emptyRegions, null, outputMessage))
+				.isInstanceOf(HttpMessageNotWritableException.class);
+	}
+
+	@Test
+	void shouldGetDefaultContentTypeForResourceRegion() {
+		Resource resource = new ClassPathResource("byterangeresource.txt", getClass());
+		ResourceRegion region = new ResourceRegion(resource, 0, 10);
+
+		MediaType contentType = converter.getDefaultContentType(region);
+		assertThat(contentType).isEqualTo(MediaType.TEXT_PLAIN);
+	}
+
+	@Test
+	void shouldGetDefaultOctetStreamContentTypeForUnknownResource() {
+		Resource resource = mock(Resource.class);
+		given(resource.getFilename()).willReturn("unknown.dat");
+		ResourceRegion region = new ResourceRegion(resource, 0, 10);
+
+		MediaType contentType = converter.getDefaultContentType(region);
+		assertThat(contentType).isEqualTo(MediaType.APPLICATION_OCTET_STREAM);
+	}
+
+	@Test
+	void shouldSupportRepeatableWritesForNonInputStreamResource() {
+		Resource resource = new ClassPathResource("byterangeresource.txt", getClass());
+		ResourceRegion region = new ResourceRegion(resource, 0, 10);
+
+		assertThat(converter.supportsRepeatableWrites(region)).isTrue();
+	}
+
+	@Test
+	void shouldNotSupportRepeatableWritesForInputStreamResource() {
+		Resource resource = mock(InputStreamResource.class);
+		ResourceRegion region = new ResourceRegion(resource, 0, 10);
+
+		assertThat(converter.supportsRepeatableWrites(region)).isFalse();
+	}
+
+	@Test
+	void shouldHandleIOExceptionWhenWritingRegion() throws Exception {
+		MockHttpOutputMessage outputMessage = new MockHttpOutputMessage();
+		Resource resource = mock(Resource.class);
+		given(resource.contentLength()).willReturn(10L);
+		given(resource.getInputStream()).willThrow(new IOException("Simulated error"));
+		ResourceRegion region = new ResourceRegion(resource, 0, 5);
+
+		// Should not throw exception
+		converter.write(region, MediaType.TEXT_PLAIN, outputMessage);
+
+		assertThat(outputMessage.getHeaders().getRange()).isEqualTo(HttpRange.parseRanges("bytes 0-4/10"));
+	}
+
+	@Test
+	void shouldHandleIOExceptionWhenWritingRegionCollection() throws Exception {
+		MockHttpOutputMessage outputMessage = new MockHttpOutputMessage();
+		Resource resource = mock(Resource.class);
+		given(resource.contentLength()).willReturn(10L);
+		given(resource.getInputStream()).willThrow(new IOException("Simulated error"));
+		ResourceRegion region = new ResourceRegion(resource, 0, 5);
+		List<ResourceRegion> regions = Collections.singletonList(region);
+
+		// Should not throw exception
+		converter.write(regions, MediaType.TEXT_PLAIN, outputMessage);
+
+		assertThat(outputMessage.getHeaders().getContentType().toString())
+				.startsWith("multipart/byteranges;boundary=");
+	}
 }