Polish contribution

See gh-29379

Author: sbrannen

spring-jdbc/src/main/java/org/springframework/jdbc/support/incrementer/MariaDBSequenceMaxValueIncrementer.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2022 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -19,11 +19,11 @@
 import javax.sql.DataSource;
 
 /**
- * {@link DataFieldMaxValueIncrementer} that retrieves the next value
- * of a given MariaDB sequence.
+ * {@link DataFieldMaxValueIncrementer} that retrieves the next value of a given
+ * MariaDB sequence.
  *
  * @author Mahmoud Ben Hassine
- * @since 6.0.0
+ * @since 6.0
  */
 public class MariaDBSequenceMaxValueIncrementer extends AbstractSequenceMaxValueIncrementer {
 

spring-jdbc/src/test/java/org/springframework/jdbc/support/DataFieldMaxValueIncrementerTests.java

@@ -169,58 +169,58 @@ void mySQLMaxValueIncrementer() throws SQLException {
 	}
 
 	@Test
-	void oracleSequenceMaxValueIncrementer() throws SQLException {
+	void mariaDBSequenceMaxValueIncrementer() throws SQLException {
 		given(dataSource.getConnection()).willReturn(connection);
 		given(connection.createStatement()).willReturn(statement);
-		given(statement.executeQuery("select myseq.nextval from dual")).willReturn(resultSet);
+		given(statement.executeQuery("select next value for myseq")).willReturn(resultSet);
 		given(resultSet.next()).willReturn(true);
 		given(resultSet.getLong(1)).willReturn(10L, 12L);
 
-		OracleSequenceMaxValueIncrementer incrementer = new OracleSequenceMaxValueIncrementer();
+		MariaDBSequenceMaxValueIncrementer incrementer = new MariaDBSequenceMaxValueIncrementer();
 		incrementer.setDataSource(dataSource);
 		incrementer.setIncrementerName("myseq");
-		incrementer.setPaddingLength(2);
+		incrementer.setPaddingLength(5);
 		incrementer.afterPropertiesSet();
 
-		assertThat(incrementer.nextLongValue()).isEqualTo(10);
-		assertThat(incrementer.nextStringValue()).isEqualTo("12");
+		assertThat(incrementer.nextStringValue()).isEqualTo("00010");
+		assertThat(incrementer.nextIntValue()).isEqualTo(12);
 
 		verify(resultSet, times(2)).close();
 		verify(statement, times(2)).close();
 		verify(connection, times(2)).close();
 	}
 
 	@Test
-	void postgresSequenceMaxValueIncrementer() throws SQLException {
+	void oracleSequenceMaxValueIncrementer() throws SQLException {
 		given(dataSource.getConnection()).willReturn(connection);
 		given(connection.createStatement()).willReturn(statement);
-		given(statement.executeQuery("select nextval('myseq')")).willReturn(resultSet);
+		given(statement.executeQuery("select myseq.nextval from dual")).willReturn(resultSet);
 		given(resultSet.next()).willReturn(true);
 		given(resultSet.getLong(1)).willReturn(10L, 12L);
 
-		PostgresSequenceMaxValueIncrementer incrementer = new PostgresSequenceMaxValueIncrementer();
+		OracleSequenceMaxValueIncrementer incrementer = new OracleSequenceMaxValueIncrementer();
 		incrementer.setDataSource(dataSource);
 		incrementer.setIncrementerName("myseq");
-		incrementer.setPaddingLength(5);
+		incrementer.setPaddingLength(2);
 		incrementer.afterPropertiesSet();
 
-		assertThat(incrementer.nextStringValue()).isEqualTo("00010");
-		assertThat(incrementer.nextIntValue()).isEqualTo(12);
+		assertThat(incrementer.nextLongValue()).isEqualTo(10);
+		assertThat(incrementer.nextStringValue()).isEqualTo("12");
 
 		verify(resultSet, times(2)).close();
 		verify(statement, times(2)).close();
 		verify(connection, times(2)).close();
 	}
 
 	@Test
-	void mariaDBSequenceMaxValueIncrementer() throws SQLException {
+	void postgresSequenceMaxValueIncrementer() throws SQLException {
 		given(dataSource.getConnection()).willReturn(connection);
 		given(connection.createStatement()).willReturn(statement);
-		given(statement.executeQuery("select next value for myseq")).willReturn(resultSet);
+		given(statement.executeQuery("select nextval('myseq')")).willReturn(resultSet);
 		given(resultSet.next()).willReturn(true);
 		given(resultSet.getLong(1)).willReturn(10L, 12L);
 
-		MariaDBSequenceMaxValueIncrementer incrementer = new MariaDBSequenceMaxValueIncrementer();
+		PostgresSequenceMaxValueIncrementer incrementer = new PostgresSequenceMaxValueIncrementer();
 		incrementer.setDataSource(dataSource);
 		incrementer.setIncrementerName("myseq");
 		incrementer.setPaddingLength(5);