wip

Author: Vincent Potucek

framework-docs/src/main/java/org/springframework/docs/core/aot/hints/testing/SampleReflectionRuntimeHintsTests.java

@@ -44,8 +44,7 @@ void shouldRegisterReflectionHints() {
 
 		// Invoke the relevant piece of code we want to test within a recording lambda
 		RuntimeHintsInvocations invocations = org.springframework.aot.test.agent.RuntimeHintsRecorder.record(() -> {
-			SampleReflection sample = new SampleReflection();
-			sample.performReflection();
+			new SampleReflection().performReflection();
 		});
 		// assert that the recorded invocations are covered by the contributed hints
 		assertThat(invocations).match(runtimeHints);

integration-tests/src/test/java/org/springframework/aot/test/ReflectionInvocationsTests.java

@@ -35,8 +35,7 @@ void sampleTest() {
 		hints.reflection().registerType(String.class);
 
 		RuntimeHintsInvocations invocations = org.springframework.aot.test.agent.RuntimeHintsRecorder.record(() -> {
-			SampleReflection sample = new SampleReflection();
-			sample.sample(); // does Method[] methods = String.class.getMethods();
+			new SampleReflection().sample(); // does Method[] methods = String.class.getMethods();
 		});
 		assertThat(invocations).match(hints);
 	}
@@ -47,8 +46,7 @@ void multipleCallsTest() {
 		hints.reflection().registerType(String.class);
 		hints.reflection().registerType(Integer.class);
 		RuntimeHintsInvocations invocations = org.springframework.aot.test.agent.RuntimeHintsRecorder.record(() -> {
-			SampleReflection sample = new SampleReflection();
-			sample.multipleCalls(); // does Method[] methods = String.class.getMethods(); methods = Integer.class.getMethods();
+			new SampleReflection().multipleCalls(); // does Method[] methods = String.class.getMethods(); methods = Integer.class.getMethods();
 		});
 		assertThat(invocations).match(hints);
 	}

integration-tests/src/test/java/org/springframework/aot/test/SampleReflection.java

@@ -26,15 +26,13 @@ public class SampleReflection {
 
 	@SuppressWarnings("unused")
 	public void sample() {
-		// -@cs[UnusedLocalVariable]
-		Method[] methods = String.class.getMethods();
+		String.class.getMethods();
 	}
 
 	@SuppressWarnings("unused")
 	public void multipleCalls() {
-		Method[] methods = String.class.getMethods();
-		// -@cs[UnusedLocalVariable]
-		methods = Integer.class.getMethods();
+		String.class.getMethods();
+		Integer.class.getMethods();
 	}
 
 }

spring-beans/src/test/java/org/springframework/beans/factory/config/ServiceLocatorFactoryBeanTests.java

@@ -122,14 +122,9 @@ void testStringArgGetter() throws Exception {
 				genericBeanDefinition(ServiceLocatorFactoryBean.class)
 				.addPropertyValue("serviceLocatorInterface", TestServiceLocator2.class)
 				.getBeanDefinition());
-
-		// test string-arg getter with null id
-		TestServiceLocator2 factory = (TestServiceLocator2) bf.getBean("factory");
-
-		factory.getTestService(null);
-		// now test with explicit id
-		factory.getTestService("testService");
-		// now verify failure on bad id
+		TestServiceLocator2 factory = (TestServiceLocator2) bf.getBean("factory"); // test string-arg getter with null id
+		factory.getTestService(null); // now test with explicit id
+		factory.getTestService("testService"); // now verify failure on bad id
 		assertThatExceptionOfType(NoSuchBeanDefinitionException.class).isThrownBy(() ->
 				factory.getTestService("bogusTestService"));
 	}