Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting on unpaged Pageable is not applied in 3.3.x series #3778

Closed
wilx opened this issue Feb 17, 2025 · 1 comment
Closed

Sorting on unpaged Pageable is not applied in 3.3.x series #3778

wilx opened this issue Feb 17, 2025 · 1 comment
Assignees
Labels
status: superseded An issue that has been superseded by another

Comments

@wilx
Copy link

wilx commented Feb 17, 2025

This is about #3476 on 3.3.x. As can be seen here

public Page<T> findAll(Pageable pageable) {
if (pageable.isUnpaged()) {
return new PageImpl<>(findAll());
}
return findAll((Specification<T>) null, pageable);
}

A change set like the 38a11d0 is missing in the 3.3.x series.

Please fix the issue on 3.3.x as well.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 17, 2025
@mp911de mp911de self-assigned this Feb 17, 2025
@mp911de
Copy link
Member

mp911de commented Feb 17, 2025

Thanks for reaching out. I backported #3761 and #3476 into the 3.3.x branch. Closing this one as duplicate.

@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2025
@mp911de mp911de added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 17, 2025
@mp911de mp911de closed this as completed Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

3 participants