Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JpaSort.JpaOrder.withUnsafe(String ... properties) is somewhat unintuitive. #2932

Open
schauder opened this issue Apr 28, 2023 · 1 comment
Labels
for: team-attention An issue we need to discuss as a team to make progress

Comments

@schauder
Copy link
Contributor

We should at the very least write some tests to document the intended behaviour and also clarify that in the documentation.

@mp911de
Copy link
Member

mp911de commented May 11, 2023

I'd vote to deprecate that method altogether as it retains the settings from the Order in a weird way for a collection of new property names.

@mp911de mp911de added the for: team-attention An issue we need to discuss as a team to make progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: team-attention An issue we need to discuss as a team to make progress
Projects
None yet
Development

No branches or pull requests

2 participants