Skip to content

Commit fcdebde

Browse files
Seol-JYmp911de
authored andcommitted
Polishing.
Replace Collection.class.isInstance with instanceof for type checking. Remove unnecessary type check for ConfigurableListableBeanFactory in postProcessBeanFactory method. Closes #3580
1 parent 303c2db commit fcdebde

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtension.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ public void registerBeansForRoot(BeanDefinitionRegistry registry, RepositoryConf
195195

196196
registerIfNotAlreadyRegistered(() -> {
197197

198-
Object value = AnnotationRepositoryConfigurationSource.class.isInstance(config) //
198+
Object value = config instanceof AnnotationRepositoryConfigurationSource //
199199
? config.getRequiredAttribute(ESCAPE_CHARACTER_PROPERTY, Character.class) //
200200
: config.getAttribute(ESCAPE_CHARACTER_PROPERTY).orElse("\\");
201201

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/EntityManagerBeanDefinitionRegistrarPostProcessor.java

+1-7
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,7 @@ public int getOrder() {
5555
@Override
5656
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {
5757

58-
if (!ConfigurableListableBeanFactory.class.isInstance(beanFactory)) {
59-
return;
60-
}
61-
62-
ConfigurableListableBeanFactory factory = beanFactory;
63-
64-
for (EntityManagerFactoryBeanDefinition definition : getEntityManagerFactoryBeanDefinitions(factory)) {
58+
for (EntityManagerFactoryBeanDefinition definition : getEntityManagerFactoryBeanDefinitions(beanFactory)) {
6559

6660
BeanFactory definitionFactory = definition.getBeanFactory();
6761

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ public void deleteAllByIdInBatch(Iterable<ID> ids) {
247247
* Some JPA providers require {@code ids} to be a {@link Collection} so we must convert if it's not already.
248248
*/
249249

250-
if (Collection.class.isInstance(ids)) {
250+
if (ids instanceof Collection) {
251251
query.setParameter("ids", ids);
252252
} else {
253253
Collection<ID> idsCollection = StreamSupport.stream(ids.spliterator(), false)

0 commit comments

Comments
 (0)