Skip to content

Commit b52e8d1

Browse files
committed
Fix setting setting id in bulkrequest.
Original Pull Request #2862 Closes #2861 (cherry picked from commit debf04b)
1 parent e86bb77 commit b52e8d1

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java

+14-13
Original file line numberDiff line numberDiff line change
@@ -545,13 +545,12 @@ public IndexRequest<?> documentIndexRequest(IndexQuery query, IndexCoordinates i
545545
Object queryObject = query.getObject();
546546

547547
if (queryObject != null) {
548-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
549-
builder //
550-
.id(id) //
548+
builder
549+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
551550
.document(elasticsearchConverter.mapObject(queryObject));
552551
} else if (query.getSource() != null) {
553-
builder //
554-
.id(query.getId()) //
552+
builder
553+
.id(query.getId())
555554
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
556555
} else {
557556
throw new InvalidDataAccessApiUsageException(
@@ -597,12 +596,13 @@ private IndexOperation<?> bulkIndexOperation(IndexQuery query, IndexCoordinates
597596
Object queryObject = query.getObject();
598597

599598
if (queryObject != null) {
600-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
601-
builder //
602-
.id(id) //
599+
builder
600+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
603601
.document(elasticsearchConverter.mapObject(queryObject));
604602
} else if (query.getSource() != null) {
605-
builder.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
603+
builder
604+
.id(query.getId())
605+
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
606606
} else {
607607
throw new InvalidDataAccessApiUsageException(
608608
"object or source is null, failed to index the document [id: " + query.getId() + ']');
@@ -638,12 +638,13 @@ private CreateOperation<?> bulkCreateOperation(IndexQuery query, IndexCoordinate
638638
Object queryObject = query.getObject();
639639

640640
if (queryObject != null) {
641-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
642-
builder //
643-
.id(id) //
641+
builder
642+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
644643
.document(elasticsearchConverter.mapObject(queryObject));
645644
} else if (query.getSource() != null) {
646-
builder.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
645+
builder
646+
.id(query.getId())
647+
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
647648
} else {
648649
throw new InvalidDataAccessApiUsageException(
649650
"object or source is null, failed to index the document [id: " + query.getId() + ']');

0 commit comments

Comments
 (0)