You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently RestClientAutoConfiguration uses NotReactiveWebApplicationCondition so that it is only enabled for non-reactive web applications which helps prevent users from accidentally blocking the event loop thread.
This foot-gun protection is less useful when virtual threads are enabled, as we configure WebFlux with an async task executor which allows blocking calls to be made for any controller method that does not return reactive types. Since RestClientAutoConfiguration provides a lot of helpful functionality, we should relax the condition to a NotReactiveWebApplicationOrVirtualThreadsEnabledCondition
The text was updated successfully, but these errors were encountered:
Currently
RestClientAutoConfiguration
usesNotReactiveWebApplicationCondition
so that it is only enabled for non-reactive web applications which helps prevent users from accidentally blocking the event loop thread.This foot-gun protection is less useful when virtual threads are enabled, as we configure WebFlux with an async task executor which allows blocking calls to be made for any controller method that does not return reactive types. Since
RestClientAutoConfiguration
provides a lot of helpful functionality, we should relax the condition to aNotReactiveWebApplicationOrVirtualThreadsEnabledCondition
The text was updated successfully, but these errors were encountered: