Add test for MariaDB, Postgres, Sqlite, MySQL

Signed-off-by: KyeongHoon Lee <[email protected]>

Author: pongdangx2

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/support/MariaDBPagingQueryProviderTests.java

@@ -16,6 +16,7 @@
 package org.springframework.batch.item.database.support;
 
 import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.Map;
 
 import org.junit.jupiter.api.Test;
@@ -26,6 +27,7 @@
 
 /**
  * @author Mahmoud Ben Hassine
+ * @author Kyeonghoon Lee
  */
 class MariaDBPagingQueryProviderTests extends AbstractSqlPagingQueryProviderTests {
 
@@ -67,6 +69,22 @@ void testGenerateRemainingPagesQueryWithGroupBy() {
 		assertEquals(sql, s);
 	}
 
+	@Test
+	void testGenerateRemainingPagesQueryWithGroupByWithAlias() {
+		pagingQueryProvider.setSelectClause("SELECT f.id, f.name, f.age");
+		pagingQueryProvider.setFromClause("FROM foo f");
+		pagingQueryProvider.setWhereClause("f.bar = 1");
+		pagingQueryProvider.setGroupClause("f.id, f.dep");
+		Map<String, Order> sortKeys = new LinkedHashMap<>();
+		sortKeys.put("f.id", Order.ASCENDING);
+		pagingQueryProvider.setSortKeys(sortKeys);
+
+		String sql = "SELECT *  FROM (SELECT f.id, f.name, f.age FROM foo f WHERE f.bar = 1 GROUP BY f.id, f.dep) AS MAIN_QRY WHERE ((id > ?)) ORDER BY id ASC LIMIT "
+				+ pageSize;
+		String s = pagingQueryProvider.generateRemainingPagesQuery(pageSize);
+		assertEquals(sql, s);
+	}
+
 	@Test
 	void testFirstPageSqlWithAliases() {
 		Map<String, Order> sorts = new HashMap<>();

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/support/MySqlPagingQueryProviderTests.java

@@ -75,12 +75,12 @@ void testGenerateRemainingPagesQueryWithGroupByWithAlias() {
 		pagingQueryProvider.setSelectClause("SELECT f.id, f.name, f.age");
 		pagingQueryProvider.setFromClause("FROM foo f");
 		pagingQueryProvider.setWhereClause("f.bar = 1");
-		pagingQueryProvider.setGroupClause("dep");
+		pagingQueryProvider.setGroupClause("f.id, f.dep");
 		Map<String, Order> sortKeys = new LinkedHashMap<>();
 		sortKeys.put("f.id", Order.ASCENDING);
 		pagingQueryProvider.setSortKeys(sortKeys);
 
-		String sql = "SELECT *  FROM (SELECT f.id, f.name, f.age FROM foo f WHERE f.bar = 1 GROUP BY dep) AS MAIN_QRY WHERE ((id > ?)) ORDER BY id ASC LIMIT "
+		String sql = "SELECT *  FROM (SELECT f.id, f.name, f.age FROM foo f WHERE f.bar = 1 GROUP BY f.id, f.dep) AS MAIN_QRY WHERE ((id > ?)) ORDER BY id ASC LIMIT "
 				+ pageSize;
 		String s = pagingQueryProvider.generateRemainingPagesQuery(pageSize);
 		assertEquals(sql, s);

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/support/PostgresPagingQueryProviderTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2022 the original author or authors.
+ * Copyright 2012-2025 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,10 +18,15 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import org.junit.jupiter.api.Test;
+import org.springframework.batch.item.database.Order;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
 
 /**
  * @author Thomas Risberg
  * @author Michael Minella
+ * @author Kyeonghoon Lee
  */
 class PostgresPagingQueryProviderTests extends AbstractSqlPagingQueryProviderTests {
 
@@ -63,6 +68,22 @@ void testGenerateRemainingPagesQueryWithGroupBy() {
 		assertEquals(sql, s);
 	}
 
+	@Test
+	void testGenerateRemainingPagesQueryWithGroupByWithAlias() {
+		pagingQueryProvider.setSelectClause("SELECT f.id, f.name, f.age");
+		pagingQueryProvider.setFromClause("FROM foo f");
+		pagingQueryProvider.setWhereClause("f.bar = 1");
+		pagingQueryProvider.setGroupClause("f.id, f.dep");
+		Map<String, Order> sortKeys = new LinkedHashMap<>();
+		sortKeys.put("f.id", Order.ASCENDING);
+		pagingQueryProvider.setSortKeys(sortKeys);
+
+		String sql = "SELECT *  FROM (SELECT f.id, f.name, f.age FROM foo f WHERE f.bar = 1 GROUP BY f.id, f.dep) AS MAIN_QRY WHERE ((id > ?)) ORDER BY id ASC LIMIT "
+				+ pageSize;
+		String s = pagingQueryProvider.generateRemainingPagesQuery(pageSize);
+		assertEquals(sql, s);
+	}
+
 	@Override
 	String getFirstPageSqlWithMultipleSortKeys() {
 		return "SELECT id, name, age FROM foo WHERE bar = 1 ORDER BY name ASC, id DESC LIMIT 100";

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/support/SqlitePagingQueryProviderTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2014-2022 the original author or authors.
+ * Copyright 2014-2025 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,11 +18,16 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import org.junit.jupiter.api.Test;
+import org.springframework.batch.item.database.Order;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
 
 /**
  * @author Thomas Risberg
  * @author Michael Minella
  * @author Luke Taylor
+ * @author Kyeonghoon Lee
  */
 class SqlitePagingQueryProviderTests extends AbstractSqlPagingQueryProviderTests {
 
@@ -64,6 +69,22 @@ void testGenerateRemainingPagesQueryWithGroupBy() {
 		assertEquals(sql, s);
 	}
 
+	@Test
+	void testGenerateRemainingPagesQueryWithGroupByWithAlias() {
+		pagingQueryProvider.setSelectClause("SELECT f.id, f.name, f.age");
+		pagingQueryProvider.setFromClause("FROM foo f");
+		pagingQueryProvider.setWhereClause("f.bar = 1");
+		pagingQueryProvider.setGroupClause("dep");
+		Map<String, Order> sortKeys = new LinkedHashMap<>();
+		sortKeys.put("f.id", Order.ASCENDING);
+		pagingQueryProvider.setSortKeys(sortKeys);
+
+		String sql = "SELECT *  FROM (SELECT f.id, f.name, f.age FROM foo f WHERE f.bar = 1 GROUP BY dep) AS MAIN_QRY WHERE ((id > ?)) ORDER BY id ASC LIMIT "
+				+ pageSize;
+		String s = pagingQueryProvider.generateRemainingPagesQuery(pageSize);
+		assertEquals(sql, s);
+	}
+
 	@Override
 	String getFirstPageSqlWithMultipleSortKeys() {
 		return "SELECT id, name, age FROM foo WHERE bar = 1 ORDER BY name ASC, id DESC LIMIT 100";