Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JDBC support for non embedded datasources #322

Closed
vladimirfx opened this issue Sep 25, 2020 · 3 comments
Closed

Add JDBC support for non embedded datasources #322

vladimirfx opened this issue Sep 25, 2020 · 3 comments
Labels
type: enhancement A general enhancement
Milestone
0.4.3

Comments

@vladimirfx
Copy link

Jdbc is usable in reactive projects for support workloads such as schema management (Liquibase https://liquibase.jira.com/browse/CORE-3419) or Quartz clustered scheduler.
@sdeleuze
Copy link
Collaborator

I am not sure about the purpose of this issue, what would you like to be fixed/supported?

@vladimirfx
Copy link
Author

IMO JDBC DSL should provide ability to connect to external (Non-embedded) database. Currently only EmbeddedDataSourceConfigurationInitializer is used in DSL:

spring-fu/kofu/src/main/kotlin/org/springframework/fu/kofu/jdbc/JdbcDsl.kt

Line 45 in d80a9d0

EmbeddedDataSourceConfigurationInitializer(dataSourceProperties).initialize(context)

Other Datasource configurators (like DataSourceConfiguration_GenericInitializer) is present in autoconfigure-adapter subproject but not used in DSLs. Or I am missing something?

@sdeleuze sdeleuze changed the title Jdbc DSL supports only embedded datasource Add JDBC support for non embedded datasources Sep 25, 2020
@sdeleuze sdeleuze added this to the 0.4.2 milestone Sep 25, 2020
pull-vert added a commit to ufoss-org/kotysa that referenced this issue Oct 30, 2020
@pull-vert
bump dependencies to Spring Framewok 5.3.0 and kotlinx-coroutines 1.4.0.
dcb9303 
Disable all testcontainers tests on kotysa-spring-jdbc until spring-projects-experimental/spring-fu#322 is fixed

fixes #24
@sdeleuze sdeleuze modified the milestones: 0.4.2, 0.5.0, 0.4.3 Oct 31, 2020
fteychene added a commit that referenced this issue Nov 18, 2020
@fteychene
Merge pull request #332 from spring-projects-experimental/feat/322_jd…
9191603 
…bc_datasource_type_onfiguration

Add JDBC support for non embedded datasources #322
@sdeleuze
Copy link
Collaborator

sdeleuze commented Nov 18, 2020 •
edited
Loading

Fixed in KoFu via #332, JaFu support will come via #339 in 0.5.0 as well as refined support that we have started to discuss with @aneveu and @fteychene.

@sdeleuze sdeleuze added the type: enhancement A general enhancement label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
0.4.3
Development

No branches or pull requests
2 participants
@sdeleuze @vladimirfx