Skip to content
This repository was archived by the owner on Apr 5, 2022. It is now read-only.

Conversation

@daydev
Copy link

@daydev daydev commented Jun 19, 2013

If I walk user through connection flow, but there's already connection for this user and provider, DuplicateConnectionException is thrown and an old connection isn't replaced with a new one.
This becomes real problem when the old connection is actually expired and so it must be replaced with a new one.
I must therefore invent some additional logic to first remove the old connection, and then add the new one. I must go to this trouble, while there exists perfectly capable updateConnection() method in ConnectionRepository.

I propose changing ConnectController, so it will update existing connection on oauth success callback if such connection already exists and create a new one otherwise.

@pivotal-issuemaster
Copy link

@daydev Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants