Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

SimpleMessageListenerContainerFactory doesn't propagate queueMessageHandler field when SimpleMessageListenerContainer bean is created via createSimpleMessageListenerContainer #795

Open
@setu9760

Description

@setu9760

Type: Bug

Component:
SQS messaging

Describe the bug
SimpleMessageListenerContainerFactory has queueMessageHandler field and has setter for this. However when public method createSimpleMessageListenerContainer is called to create the actual bean SimpleMessageListenerContainer this field is not propagated. Ideally for the factory bean we would want all the relevant properties/fields propagated to the underlying bean without having to manually inject it twice in factory and then the underlying bean.

Sample

@Bean
@Primary
public SimpleMessageListenerContainerFactory simpleMessageListenerContainerFactory(
    QueueMessageHandler queueMessageHandler, AmazonSQSAsync amazonSqs) {
  var factory = new SimpleMessageListenerContainerFactory();
  factory.setQueueMessageHandler(queueMessageHandler);
  factory.setAmazonSqs(amazonSqs);
  factory.setAutoStartup(true);
  factory.setMaxNumberOfMessages(1);
  return factory;
}

@Bean
@Primary
public SimpleMessageListenerContainer simpleMessageListenerContainer(
    SimpleMessageListenerContainerFactory simpleMessageListenerContainerFactory,
    QueueMessageHandler queueMessageHandler) {
  var simpleMessageListenerContainer= simpleMessageListenerContainerFactory.createSimpleMessageListenerContainer();
  simpleMessageListenerContainer.setMessageHandler(queueMessageHandler);
  return simpleMessageListenerContainer;
}

in the above code the simpleMessageListenerContainer.setMessageHandler(queueMessageHandler); line shouldn't be required and the call simpleMessageListenerContainerFactory.createSimpleMessageListenerContainer() should ensure all fields from factory are injected into the bean.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions