Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration with Backstage catalog service #35

Open
fastfrwrd opened this issue Jun 17, 2020 · 1 comment
Open

integration with Backstage catalog service #35

fastfrwrd opened this issue Jun 17, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@fastfrwrd
Copy link
Collaborator

fastfrwrd commented Jun 17, 2020

Problem

At Spotify, we need the Lighthouse audits to tightly integrate with Backstage's catalog service, particularly when used with the Backstage plugin.

  • as a developer viewing a website component, I want to see all audits run for my website.
  • as a developer viewing a website component, I want to run new audits for my website.

Proposed Solution

Note: This solution could be a path forward for many of the services we open source which have a hard dependency on the currently internal catalog service @ Spotify.

I would propose that lighthouse-audit-service continue to work without a catalog id, but rather add a kubernetes-like metadata field to every entry. This could be a JSON field in the postgres DB, and you could look up items by their metadata. We could support nuanced operators to allow for startsWith, endsWith lookups.

# obviously, this would be url encoded; not encoding for the sake of readability
http://lighthouse/v1/audits?metadata={"foo": { "op": "=", "value": "bar" }}

Then, when Lighthouse audits are created via Backstage, we would create them with the catalog entry's id as metadata.

In the Backstage plugin, we'd still have the top-level view, but we would also add component-level and things-l-own-level views for viewing audits and their trends.

@fastfrwrd fastfrwrd added the enhancement New feature or request label Jun 17, 2020
@stefanalund
Copy link

Awesome to see you are starting to think about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants