refctor: change _victoria_create_index to _cloud_create_index (#139)

**Issue number:**

### PR Type

**What kind of change does this PR introduce?**
* [ ] Feature
* [ ] Bug Fix
* [X] Refactoring (no functional or API changes)
* [ ] Documentation Update
* [ ] Maintenance (dependency updates, CI, etc.)

## Summary
This PR addresses
#135 (comment)
and introduces refactoring changes.

Tested: 

https://cd.splunkdev.com/taautomation/ta-automation-compatibility-tests/-/pipelines/28546879

https://cd.splunkdev.com/taautomation/ta-automation-compatibility-tests/-/pipelines/28546918

https://cd.splunkdev.com/taautomation/ta-automation-compatibility-tests/-/pipelines/28546801

https://github.com/splunk/splunk-add-on-for-salesforce/actions/runs/16812128639
https://github.com/splunk/splunk-add-on-for-box/actions/runs/16812014592

### Changes

Please provide a summary of the changes.

### User experience

Please describe the user experience before and after this change.
Screenshots are welcome for additional context.

## Checklist

If an item doesn't apply to your changes, leave it unchecked.

* [ ] I have performed a self-review of this change according to the
[development
guidelines](https://splunk.github.io/addonfactory-ucc-test/contributing/#development-guidelines)
* [ ] Tests have been added/modified to cover the changes [(testing
doc)](https://splunk.github.io/addonfactory-ucc-test/contributing/#build-and-test)
* [ ] Changes are documented
* [ ] PR title and description follows the [contributing
principles](https://splunk.github.io/addonfactory-ucc-test/contributing/#pull-requests)

Author: kdoroszko-splunk

splunk_add_on_ucc_modinput_test/common/splunk_instance.py

@@ -87,6 +87,7 @@ def _get_index_from_classic_instance(
     def _get_index(
         index_name: str,
         client_service: SplunkServicePool,
+        is_cloud: bool = False,
         acs_stack: str | None = None,
         acs_server: str | None = None,
         splunk_token: str | None = None,
@@ -96,18 +97,14 @@ def _get_index(
             for i in client_service.indexes.iter(datatype="all")
         ):
             return client_service.indexes[index_name]
-        else:
-            if (
-                "splunkcloud.com" in client_service._host.lower()
-                and not client_service._host.startswith(acs_stack)
-            ):
-                return Configuration._get_index_from_classic_instance(
-                    index_name,
-                    client_service,
-                    acs_stack,
-                    acs_server,
-                    splunk_token,
-                )
+        if is_cloud and not client_service._host.startswith(acs_stack):
+            return Configuration._get_index_from_classic_instance(
+                index_name,
+                client_service,
+                acs_stack,
+                acs_server,
+                splunk_token,
+            )
         return None
 
     @staticmethod
@@ -132,7 +129,7 @@ def _validate_index_name(index_name: str) -> None:
             raise ValueError(reason)
 
     @staticmethod
-    def _victoria_create_index(
+    def _cloud_create_index(
         index_name: str,
         *,
         datatype: str,
@@ -250,6 +247,7 @@ def _create_index(
         if Configuration._get_index(
             index_name,
             client_service,
+            is_cloud,
             acs_stack,
             acs_server,
             splunk_token,
@@ -258,7 +256,7 @@ def _create_index(
             logger.critical(reason)
             pytest.exit(reason)
         if is_cloud:
-            Configuration._victoria_create_index(
+            Configuration._cloud_create_index(
                 index_name,
                 datatype=datatype,
                 acs_stack=acs_stack,
@@ -268,6 +266,7 @@ def _create_index(
             created_index = Configuration._get_index(
                 index_name,
                 client_service,
+                is_cloud,
                 acs_stack,
                 acs_server,
                 splunk_token,

splunk_add_on_ucc_modinput_test/functional/splunk/client.py

@@ -164,6 +164,7 @@ def get_index(self, index_name: str) -> Index | None:
         return self.config._get_index(
             index_name,
             self.splunk,
+            is_cloud=self._is_cloud,
             acs_stack=self.config.acs_stack if self._is_cloud else None,
             acs_server=self.config.acs_server if self._is_cloud else None,
             splunk_token=self.config.token if self._is_cloud else None,