Skip to content

[TS] Using SplitIO namespace from JS-commons for reusability #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: type_definitions_ts_test
Choose a base branch
from
Open

[TS] Using SplitIO namespace from JS-commons for reusability #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbec3e8
reuse declaration file from JS-commons
EmilianoSanchez Aug 10, 2022
cfdbf5a
clean up IPluggableSettings interface
EmilianoSanchez Aug 22, 2022
d9f2237
upgrade js-commons
EmilianoSanchez Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
},
"homepage": "https://github.com/splitio/react-native-client#readme",
"dependencies": {
"@splitsoftware/splitio-commons": "1.6.0"
"@splitsoftware/splitio-commons": "1.6.2-rc.3"
},
"devDependencies": {
"@react-native-community/eslint-config": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/platform/getModules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function getModules(settings: ISettings): ISdkFactoryParams {

platform,

storageFactory: settings.storage,
storageFactory: settings.storage as ISdkFactoryParams['storageFactory'],

splitApiFactory,

Expand Down
Loading