Skip to content

Commit 076151b

Browse files
Test refactors
1 parent b2df913 commit 076151b

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

src/__tests__/SplitFactory.test.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ describe('SplitFactory', () => {
3131
expect(isTimedout).toBe(false);
3232
expect(isDestroyed).toBe(false);
3333
expect(lastUpdate).toBe(0);
34-
expect((factory as SplitIO.ISDK).settings.version).toContain('react-');
34+
expect((factory as SplitIO.IBrowserSDK).settings.version).toContain('react-');
3535
return null;
3636
}}
3737
</SplitFactory>
@@ -55,7 +55,7 @@ describe('SplitFactory', () => {
5555
expect(isTimedout).toBe(false);
5656
expect(isDestroyed).toBe(false);
5757
expect(lastUpdate).toBe((outerFactory.client() as IClientWithContext).__getStatus().lastUpdate);
58-
expect((factory as SplitIO.ISDK).settings.version).toBe(outerFactory.settings.version);
58+
expect((factory as SplitIO.IBrowserSDK).settings.version).toBe(outerFactory.settings.version);
5959
return null;
6060
}}
6161
</SplitFactory>
@@ -239,7 +239,7 @@ describe('SplitFactory', () => {
239239
<SplitFactory config={sdkBrowser} >
240240
{({ factory }) => {
241241
expect(__factories.size).toBe(1);
242-
destroyMainClientSpy = jest.spyOn((factory as SplitIO.ISDK).client(), 'destroy');
242+
destroyMainClientSpy = jest.spyOn((factory as SplitIO.IBrowserSDK).client(), 'destroy');
243243
return (
244244
<SplitClient splitKey='other_key' >
245245
{({ client }) => {
@@ -267,7 +267,7 @@ describe('SplitFactory', () => {
267267
{({ factory }) => {
268268
// if factory is provided as a prop, `factories` cache is not modified
269269
expect(__factories.size).toBe(0);
270-
destroyMainClientSpy = jest.spyOn((factory as SplitIO.ISDK).client(), 'destroy');
270+
destroyMainClientSpy = jest.spyOn((factory as SplitIO.IBrowserSDK).client(), 'destroy');
271271
return (
272272
<SplitClient splitKey='other_key' >
273273
{({ client }) => {

src/__tests__/SplitFactoryProvider.test.tsx

+4-8
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const logSpy = jest.spyOn(console, 'log');
1414
import { ISplitFactoryChildProps } from '../types';
1515
import { SplitFactoryProvider } from '../SplitFactoryProvider';
1616
import { SplitClient } from '../SplitClient';
17-
import { SplitContext } from '../SplitContext';
17+
import { INITIAL_CONTEXT, SplitContext } from '../SplitContext';
1818
import { __factories, IClientWithContext } from '../utils';
1919
import { WARN_SF_CONFIG_AND_FACTORY } from '../constants';
2020

@@ -55,7 +55,7 @@ describe('SplitFactoryProvider', () => {
5555
expect(isTimedout).toBe(false);
5656
expect(isDestroyed).toBe(false);
5757
expect(lastUpdate).toBe((outerFactory.client() as IClientWithContext).__getStatus().lastUpdate);
58-
expect((factory as SplitIO.ISDK).settings.version).toBe(outerFactory.settings.version);
58+
expect((factory as SplitIO.IBrowserSDK).settings.version).toBe(outerFactory.settings.version);
5959
return null;
6060
}}
6161
</SplitFactoryProvider>
@@ -301,11 +301,7 @@ describe('SplitFactoryProvider', () => {
301301
return (
302302
<SplitContext.Consumer>
303303
{(value) => {
304-
expect(value.factory).toBe(null);
305-
expect(value.client).toBe(null);
306-
expect(value.isReady).toBe(false);
307-
expect(value.isTimedout).toBe(false);
308-
expect(value.lastUpdate).toBe(0);
304+
expect(value).toEqual(INITIAL_CONTEXT);
309305
done();
310306
return null;
311307
}}
@@ -338,7 +334,7 @@ describe('SplitFactoryProvider', () => {
338334

339335
test('cleans up on update and unmount if config prop is provided.', () => {
340336
let renderTimes = 0;
341-
const createdFactories = new Set<SplitIO.ISDK>();
337+
const createdFactories = new Set<SplitIO.IBrowserSDK>();
342338
const clientDestroySpies: jest.SpyInstance[] = [];
343339
const outerFactory = SplitSdk(sdkBrowser);
344340

0 commit comments

Comments
 (0)