Skip to content

Commit f99c527

Browse files
committed
Fixed split view
1 parent 91b48ee commit f99c527

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

client/src/main/java/io/split/client/api/SplitView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public class SplitView {
2828
public List<String> sets;
2929
public String defaultTreatment;
3030
public boolean impressionsDisabled;
31-
public String prerequisites;
31+
public List<Prerequisites> prerequisites;
3232

3333
public static SplitView fromParsedSplit(ParsedSplit parsedSplit) {
3434
SplitView splitView = new SplitView();
@@ -50,7 +50,7 @@ public static SplitView fromParsedSplit(ParsedSplit parsedSplit) {
5050
splitView.treatments = new ArrayList<String>(treatments);
5151
splitView.configs = parsedSplit.configurations() == null? Collections.<String, String>emptyMap() : parsedSplit.configurations() ;
5252
splitView.impressionsDisabled = parsedSplit.impressionsDisabled();
53-
splitView.prerequisites = parsedSplit.prerequisites() != null ? parsedSplit.prerequisites().toString(): "";
53+
splitView.prerequisites = parsedSplit.prerequisites() != null ? parsedSplit.prerequisites().getPrerequisites(): new ArrayList<>();
5454

5555
return splitView;
5656
}

client/src/main/java/io/split/engine/matchers/PrerequisitesMatcher.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ public PrerequisitesMatcher(List<Prerequisites> prerequisites) {
1515
_prerequisites = prerequisites;
1616
}
1717

18+
public List<Prerequisites> getPrerequisites() { return _prerequisites; }
19+
1820
@Override
1921
public boolean match(Object matchValue, String bucketingKey, Map<String, Object> attributes, EvaluationContext evaluationContext) {
2022
if (matchValue == null) {

client/src/test/java/io/split/client/SplitManagerImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void splitCallWithExistentSplit() {
8787
Assert.assertEquals("off", theOne.treatments.get(0));
8888
Assert.assertEquals(0, theOne.configs.size());
8989
Assert.assertEquals("off", theOne.defaultTreatment);
90-
Assert.assertEquals(new PrerequisitesMatcher(Lists.newArrayList(prereq)).toString(), theOne.prerequisites);
90+
Assert.assertEquals(Lists.newArrayList(prereq), theOne.prerequisites);
9191
}
9292

9393
@Test

0 commit comments

Comments
 (0)