Skip to content

Commit 1295f9a

Browse files
committed
Updated rb segment storage for in memory
1 parent cd9c345 commit 1295f9a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

storage/inmemory/mutexmap/rulebasedsegment.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,11 @@ func NewRuleBasedSegmentsStorage() *RuleBasedSegmentsStorageImpl {
2828
}
2929

3030
// Update atomically registers new rule-based segments, removes archived ones and updates the change number
31-
func (r *RuleBasedSegmentsStorageImpl) Update(toAdd []dtos.RuleBasedSegmentDTO, toRemove []dtos.RuleBasedSegmentDTO, till int64) {
31+
func (r *RuleBasedSegmentsStorageImpl) Update(toAdd []dtos.RuleBasedSegmentDTO, toRemove []dtos.RuleBasedSegmentDTO, till int64) error {
3232
r.mutex.Lock()
3333
defer r.mutex.Unlock()
3434
r.update(toAdd, toRemove, till)
35+
return nil
3536
}
3637

3738
// Update atomically registers new rule-based, removes archived ones and updates the change number

storage/redis/splits_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,12 @@ package redis
33
import (
44
"encoding/json"
55
"errors"
6+
"slices"
67
"strconv"
78
"sync/atomic"
89
"testing"
910
"time"
1011

11-
"golang.org/x/exp/slices"
12-
1312
"github.com/splitio/go-split-commons/v8/conf"
1413
"github.com/splitio/go-split-commons/v8/dtos"
1514
"github.com/splitio/go-split-commons/v8/engine/grammar/constants"

0 commit comments

Comments
 (0)