Implemented lint feature for EnvOp and TestSpec

Signed-off-by: Nichol Yip <[email protected]>

Author: Nichol Yip

crates/spk-schema/crates/ident/Cargo.toml

@@ -19,6 +19,7 @@ format_serde_error = { version = "0.3", default_features = false, features = [
 itertools = { workspace = true }
 nom = { workspace = true }
 nom-supreme = { workspace = true }
+lint_proc_macro = { workspace = true }
 relative-path = "1.3"
 serde = { workspace = true, features = ["derive"] }
 serde_yaml = { workspace = true }

crates/spk-schema/src/environ.rs

@@ -38,7 +38,7 @@ pub enum OpKind {
 }
 
 /// An operation performed to the environment
-#[derive(Clone, Debug, Eq, Hash, Lint, Ord, PartialEq, PartialOrd, Serialize)]
+#[derive(Clone, Debug, Eq, Hash, Ord, PartialEq, PartialOrd, Serialize)]
 #[serde(untagged)]
 pub enum EnvOp {
     Append(AppendEnv),
@@ -341,7 +341,7 @@ impl<'de> serde::de::Visitor<'de> for EnvOpVisitor {
 ///
 /// The separator used defaults to the path separator for the current
 /// host operating system (':' for unix, ';' for windows)
-#[derive(Clone, Debug, Eq, Hash, Ord, PartialEq, PartialOrd, Serialize)]
+#[derive(Clone, Debug, Eq, Hash, Lint, Ord, PartialEq, PartialOrd, Serialize)]
 pub struct AppendEnv {
     pub append: String,
     pub value: String,
@@ -430,7 +430,7 @@ impl EnvPriority {
 ///
 /// The separator used defaults to the path separator for the current
 /// host operating system (':' for unix, ';' for windows)
-#[derive(Clone, Debug, Eq, Hash, Ord, PartialEq, PartialOrd, Serialize)]
+#[derive(Clone, Debug, Eq, Hash, Lint, Ord, PartialEq, PartialOrd, Serialize)]
 pub struct PrependEnv {
     pub prepend: String,
     pub value: String,
@@ -476,7 +476,7 @@ impl PrependEnv {
 }
 
 /// Operates on an environment variable by setting it to a value
-#[derive(Clone, Debug, Eq, Hash, Ord, PartialEq, PartialOrd, Serialize)]
+#[derive(Clone, Debug, Eq, Hash, Lint, Ord, PartialEq, PartialOrd, Serialize)]
 pub struct SetEnv {
     pub set: String,
     pub value: String,

crates/spk-schema/src/install_spec.rs

@@ -36,9 +36,12 @@ where
     D: Default,
 {
     fn lints(&mut self) -> Vec<String> {
-        // for env in self.environment.iter_mut() {
-        //     self.lints.extend(std::mem::take(&mut env.lints));
-        // }
+        for env in self.environment.iter_mut() {
+            self.lints.extend(std::mem::take(
+                &mut env.lints.iter().map(|l| env.item.lints(l)).collect_vec(),
+            ));
+        }
+
         std::mem::take(&mut self.lints)
     }
 }

crates/spk-schema/src/v0/spec.rs

@@ -1023,7 +1023,13 @@ impl<B, T> Lints for SpecVisitor<B, T> {
 
         if let Some(tests) = self.tests.as_mut() {
             for test in tests.iter_mut() {
-                lint_messages.extend(std::mem::take(&mut test.lints));
+                lint_messages.extend(std::mem::take(
+                    &mut test
+                        .lints
+                        .iter()
+                        .map(|l| test.item.generate_lints(l))
+                        .collect_vec(),
+                ));
             }
         }
 

crates/spk-schema/src/v0/test_spec.rs

@@ -101,7 +101,7 @@ impl<'de> serde::de::Visitor<'de> for TestSpecVisitor {
                 "selectors" => self.selectors = map.next_value::<Vec<OptionMap>>()?,
                 "requirements" => self.requirements = map.next_value::<Vec<Request>>()?,
                 unknown_key => {
-                    // self.lints.push(self.generate_lints(unknown_key));
+                    self.lints.push(unknown_key.to_string());
                     map.next_value::<serde::de::IgnoredAny>()?;
                 }
             }