-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fermyon
namespace in Spin WIT
#3010
Comments
@itowlson is there a way we could make |
Given that we need to continue supporting the existing names I'd propose leaving existing interfaces alone until actual revisions are needed. Some existing interfaces probably won't ever need to change again, especially where WASI equivalents are stabilizing (like wasi-keyvalue). We did something similar with the Spin-specific HTTP interfaces when wasi-http stabilized; it did not get migrated to the 2.0 package. When we do need to update an interface, I'd suggest renaming to We should pick a new name for the package holding the Spin world(s) since this can be visible in WIT tooling. Maybe |
+1 for leaving existing interfaces alone. Renaming existing interfaces seems like it would break all existing code. Agree we should make |
Can we rename existing namespaces for Spin 4.0 and still maintain the old naming for 3.0 and lower packages? Essentially, if you inspected spin components in 4.0, ideally the word |
We can create parallel packages and interfaces (e.g. Spin must still export the vendorful packages/interfaces. Components built with pre-CNCF SDKs will still import the vendorful packages/interfaces. But yes we can (and should) make it so that components built with new Spin SDKs will import only neutral interfaces, opening a path to deprecating the vendorful packages/interfaces in time. |
I was about to write what @itowlson wrote 🙂. I was hoping we could do that migration lazily as needed but if we need to do it all at once we certainly can, it will just require a bunch of duplicate code in Spin. |
The Spin WIT files oftentimes use
fermyon
as the namespace for the packages. For example, the Spin 3.0 package isfermyon:[email protected]
. As Spin is now moving to the CNCF, this namespace should be changed to something vendor neutral. The next major release of Spin is a good opportunity for this. We should start brainstorming naming options.The text was updated successfully, but these errors were encountered: