Skip to content

Commit 4461b03

Browse files
committed
Fix bad rebase
Signed-off-by: Caleb Schoepp <[email protected]>
1 parent b4a97e6 commit 4461b03

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

Cargo.lock

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/factor-observe/src/lib.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ impl Factor for ObserveFactor {
3636

3737
fn prepare<T: spin_factors::RuntimeFactors>(
3838
&self,
39-
ctx: spin_factors::PrepareContext<Self>,
40-
_builders: &mut spin_factors::InstanceBuilders<T>,
39+
ctx: spin_factors::PrepareContext<T, Self>,
4140
) -> anyhow::Result<Self::InstanceBuilder> {
4241
// TODO(Lann): Is it fine that we're using BoxedTracer and BoxedSpan? Are there perf tradeoffs?
4342
// TODO(Lann): Would it make sense to put the tracer on the app state and just hold a reference to it in the instance state?

crates/factor-outbound-http/src/lib.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ impl Factor for OutboundHttpFactor {
6464
let outbound_networking = ctx.instance_builder::<OutboundNetworkingFactor>()?;
6565
let allowed_hosts = outbound_networking.allowed_hosts();
6666
let component_tls_configs = outbound_networking.component_tls_configs().clone();
67-
let observe_context = builders.get_mut::<ObserveFactor>()?.get_observe_context();
67+
let observe_context = ctx
68+
.instance_builder::<ObserveFactor>()?
69+
.get_observe_context();
6870
Ok(InstanceState {
6971
wasi_http_ctx: WasiHttpCtx::new(),
7072
allowed_hosts,

crates/runtime-factors/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ clap = { version = "3.1.18", features = ["derive", "env"] }
1919
spin-common = { path = "../common" }
2020
spin-factor-key-value = { path = "../factor-key-value" }
2121
spin-factor-llm = { path = "../factor-llm" }
22+
spin-factor-observe = { path = "../factor-observe" }
2223
spin-factor-outbound-http = { path = "../factor-outbound-http" }
2324
spin-factor-outbound-mqtt = { path = "../factor-outbound-mqtt" }
2425
spin-factor-outbound-mysql = { path = "../factor-outbound-mysql" }

0 commit comments

Comments
 (0)