Merge pull request #162 from tech-wolf-tw/fix/issue-153-strip-timestamp-prefix-migration

Fix: Migration Name Prefixed with by timestamp twice

Author: freekmurze

src/PackageServiceProvider.php

@@ -373,9 +373,15 @@ protected function generateMigrationName(string $migrationFileName, Carbon $now)
             }
         }
 
+        $migrationFileName = self::stripTimestampPrefix($migrationFileName);
         $timestamp = $now->format('Y_m_d_His');
-        $migrationFileName = Str::of($migrationFileName)->snake()->finish('.php');
+        $formattedFileName = Str::of($migrationFileName)->snake()->finish('.php');
 
-        return database_path($migrationsPath . $timestamp . '_' . $migrationFileName);
+        return database_path("{$migrationsPath}{$timestamp}_{$formattedFileName}");
+    }
+
+    private static function stripTimestampPrefix(string $filename): string
+    {
+        return preg_replace('/^\d{4}_\d{2}_\d{2}_\d{6}_/', '', $filename);
     }
 }

tests/PackageServiceProviderTests/PackageDiscoversMigrationsTest.php

@@ -60,6 +60,6 @@ public function configurePackage(Package $package)
     /** @var \Illuminate\Database\Migrations\Migrator $migrator */
     $migrator = app('migrator');
 
-    $this->assertCount(5, $migrator->paths());
-    $this->assertStringContainsString('laravel_package_tools', $migrator->paths()[0]);
+    $this->assertCount(6, $migrator->paths());
+    $this->assertStringContainsString('laravel_package_tools', $migrator->paths()[1]);
 });

tests/PackageServiceProviderTests/PackageMigrationTest.php

@@ -13,6 +13,7 @@ public function configurePackage(Package $package)
             ->name('laravel-package-tools')
             ->hasMigration('create_another_laravel_package_tools_table')
             ->hasMigration('create_regular_laravel_package_tools_table')
+            ->hasMigration('2025_03_14_011123_create_custom_table')
             ->runsMigrations();
     }
 }
@@ -28,6 +29,15 @@ public function configurePackage(Package $package)
     assertMigrationPublished('create_another_laravel_package_tools_table.php');
 });
 
+it('can publish migration with a prefixed timestamp', function () {
+    $this
+        ->artisan('vendor:publish --tag=package-tools-migrations')
+        ->doesntExpectOutput('hey')
+        ->assertExitCode(0);
+
+    assertMigrationPublished('2020_01_01_000003_create_custom_table.php');
+});
+
 it('can publish the migration without being stubbed', function () {
     $this
         ->artisan('vendor:publish --tag=package-tools-migrations')
@@ -80,6 +90,6 @@ public function configurePackage(Package $package)
     /** @var \Illuminate\Database\Migrations\Migrator $migrator */
     $migrator = app('migrator');
 
-    $this->assertCount(2, $migrator->paths());
+    $this->assertCount(3, $migrator->paths());
     $this->assertStringContainsString('laravel_package_tools', $migrator->paths()[0]);
 });

tests/TestPackage/database/migrations/2025_03_14_011123_create_custom_table.php.stub

@@ -0,0 +1,17 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class CreateCustomTable extends Migration
+{
+    public function up()
+    {
+        Schema::create('custom', function (Blueprint $table) {
+            $table->bigIncrements('id');
+
+            $table->timestamps();
+        });
+    }
+}