Skip to content

Commit 4619a5c

Browse files
committed
avoid breaking change by removing void typehints
1 parent 7969258 commit 4619a5c

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

.phpunit.cache/test-results

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"version":"pest_2.36.0","defects":[],"times":{"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\AskToRunMigrationsTest::__pest_evaluable_it_can_ask_to_run_the_migrations":0.042,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\AssetsTest::__pest_evaluable_it_can_install_the_assets":0.009,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\ConfigFileTest::__pest_evaluable_it_can_install_the_config_file":0.001,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\CopyAndRegisterServiceProviderInAppTest::__pest_evaluable_it_can_copy_and_register_the_service_provider_in_the_app":0.003,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\EndWithTest::__pest_evaluable_it_can_execute_the_end_with":0.001,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\MigrationTest::__pest_evaluable_it_can_install_the_migrations":0.002,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\StarRepoTest::__pest_evaluable_it_can_propose_to_star_the_repo":0.001,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\StartWithTest::__pest_evaluable_it_can_execute_the_start_with":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageAssetsTest::__pest_evaluable_it_can_publish_the_assets":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageCommandTest::__pest_evaluable_it_can_execute_a_registered_commands":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageCommandWithinAppTest::__pest_evaluable_it_can_execute_a_registered_command_in_the_context_of_the_app":0.011,"P\\Tests\\PackageServiceProviderTests\\PackageCommandsTest::__pest_evaluable_it_can_execute_a_registered_commands":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageConfigTest::__pest_evaluable_it_can_register_the_config_file":0,"P\\Tests\\PackageServiceProviderTests\\PackageConfigTest::__pest_evaluable_it_can_publish_the_config_file":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageDiscoversMigrationsTest::__pest_evaluable_it_publishes_discovered_migrations":0.003,"P\\Tests\\PackageServiceProviderTests\\PackageDiscoversMigrationsTest::__pest_evaluable_it_can_publish_the_migration_without_being_stubbed":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageDiscoversMigrationsTest::__pest_evaluable_it_does_not_overwrite_the_existing_migration":0.004,"P\\Tests\\PackageServiceProviderTests\\PackageDiscoversMigrationsTest::__pest_evaluable_it_can_run_migrations_which_registers_them":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_can_publish_the_migration":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_can_publish_the_migration_without_being_stubbed":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_does_not_overwrite_the_existing_migration":0.003,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_does_overwrite_the_existing_migration_with_force":0.003,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_can_run_migrations_which_registers_them":0,"P\\Tests\\PackageServiceProviderTests\\PackageMultipleConfigTest::__pest_evaluable_it_can_register_multiple_config_files":0,"P\\Tests\\PackageServiceProviderTests\\PackageNameTest::__pest_evaluable_it_will_not_blow_up_when_a_name_is_set":0,"P\\Tests\\PackageServiceProviderTests\\PackagePublishableProviderTest::__pest_evaluable_it_can_publish_a_service_provider":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageRouteTest::__pest_evaluable_it_can_load_the_route":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageRouteTest::__pest_evaluable_it_can_load_multiple_route":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageRoutesTest::__pest_evaluable_it_can_load_the_route":0,"P\\Tests\\PackageServiceProviderTests\\PackageRoutesTest::__pest_evaluable_it_can_load_multiple_route":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageSharedDataTest::__pest_evaluable_it_can_share_data_with_all_views":0.005,"P\\Tests\\PackageServiceProviderTests\\PackageTranslationsTest::__pest_evaluable_it_can_load_the_translations":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageTranslationsTest::__pest_evaluable_it_can_publish_the_translations":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageViewComponentsTest::__pest_evaluable_it_can_load_the_view_components":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageViewComponentsTest::__pest_evaluable_it_can_publish_the_view_components":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageViewComposerTest::__pest_evaluable_it_can_load_the_view_composer_and_render_shared_data":0,"P\\Tests\\PackageServiceProviderTests\\PackageViewsTest::__pest_evaluable_it_can_load_the_views":0,"P\\Tests\\PackageServiceProviderTests\\PackageViewsTest::__pest_evaluable_it_can_publish_the_views":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageViewsWithCustomNamespaceTest::__pest_evaluable_it_can_load_the_views_with_a_custom_namespace":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageViewsWithCustomNamespaceTest::__pest_evaluable_it_can_publish_the_views_with_a_custom_namespace":0.001}}
1+
{"version":"pest_2.36.0","defects":[],"times":{"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\AskToRunMigrationsTest::__pest_evaluable_it_can_ask_to_run_the_migrations":0.043,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\AssetsTest::__pest_evaluable_it_can_install_the_assets":0.01,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\ConfigFileTest::__pest_evaluable_it_can_install_the_config_file":0.002,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\CopyAndRegisterServiceProviderInAppTest::__pest_evaluable_it_can_copy_and_register_the_service_provider_in_the_app":0.003,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\EndWithTest::__pest_evaluable_it_can_execute_the_end_with":0.001,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\MigrationTest::__pest_evaluable_it_can_install_the_migrations":0.002,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\StarRepoTest::__pest_evaluable_it_can_propose_to_star_the_repo":0.001,"P\\Tests\\PackageServiceProviderTests\\InstallCommandTests\\StartWithTest::__pest_evaluable_it_can_execute_the_start_with":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageAssetsTest::__pest_evaluable_it_can_publish_the_assets":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageCommandTest::__pest_evaluable_it_can_execute_a_registered_commands":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageCommandWithinAppTest::__pest_evaluable_it_can_execute_a_registered_command_in_the_context_of_the_app":0.012,"P\\Tests\\PackageServiceProviderTests\\PackageCommandsTest::__pest_evaluable_it_can_execute_a_registered_commands":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageConfigTest::__pest_evaluable_it_can_register_the_config_file":0,"P\\Tests\\PackageServiceProviderTests\\PackageConfigTest::__pest_evaluable_it_can_publish_the_config_file":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageDiscoversMigrationsTest::__pest_evaluable_it_publishes_discovered_migrations":0.003,"P\\Tests\\PackageServiceProviderTests\\PackageDiscoversMigrationsTest::__pest_evaluable_it_can_publish_the_migration_without_being_stubbed":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageDiscoversMigrationsTest::__pest_evaluable_it_does_not_overwrite_the_existing_migration":0.004,"P\\Tests\\PackageServiceProviderTests\\PackageDiscoversMigrationsTest::__pest_evaluable_it_can_run_migrations_which_registers_them":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_can_publish_the_migration":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_can_publish_the_migration_without_being_stubbed":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_does_not_overwrite_the_existing_migration":0.003,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_does_overwrite_the_existing_migration_with_force":0.003,"P\\Tests\\PackageServiceProviderTests\\PackageMigrationTest::__pest_evaluable_it_can_run_migrations_which_registers_them":0,"P\\Tests\\PackageServiceProviderTests\\PackageMultipleConfigTest::__pest_evaluable_it_can_register_multiple_config_files":0,"P\\Tests\\PackageServiceProviderTests\\PackageNameTest::__pest_evaluable_it_will_not_blow_up_when_a_name_is_set":0,"P\\Tests\\PackageServiceProviderTests\\PackagePublishableProviderTest::__pest_evaluable_it_can_publish_a_service_provider":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageRouteTest::__pest_evaluable_it_can_load_the_route":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageRouteTest::__pest_evaluable_it_can_load_multiple_route":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageRoutesTest::__pest_evaluable_it_can_load_the_route":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageRoutesTest::__pest_evaluable_it_can_load_multiple_route":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageSharedDataTest::__pest_evaluable_it_can_share_data_with_all_views":0.004,"P\\Tests\\PackageServiceProviderTests\\PackageTranslationsTest::__pest_evaluable_it_can_load_the_translations":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageTranslationsTest::__pest_evaluable_it_can_publish_the_translations":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageViewComponentsTest::__pest_evaluable_it_can_load_the_view_components":0.002,"P\\Tests\\PackageServiceProviderTests\\PackageViewComponentsTest::__pest_evaluable_it_can_publish_the_view_components":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageViewComposerTest::__pest_evaluable_it_can_load_the_view_composer_and_render_shared_data":0,"P\\Tests\\PackageServiceProviderTests\\PackageViewsTest::__pest_evaluable_it_can_load_the_views":0,"P\\Tests\\PackageServiceProviderTests\\PackageViewsTest::__pest_evaluable_it_can_publish_the_views":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageViewsWithCustomNamespaceTest::__pest_evaluable_it_can_load_the_views_with_a_custom_namespace":0.001,"P\\Tests\\PackageServiceProviderTests\\PackageViewsWithCustomNamespaceTest::__pest_evaluable_it_can_publish_the_views_with_a_custom_namespace":0.001}}

src/PackageServiceProvider.php

+14-14
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function newPackage(): Package
4545
return new Package();
4646
}
4747

48-
public function registerConfigs(): void
48+
public function registerConfigs()
4949
{
5050
if (empty($this->package->configFileNames)) {
5151
return;
@@ -117,7 +117,7 @@ protected function bootAssets(): void
117117
$this->publishes([$vendorAssets => $appAssets], "{$this->package->shortName()}-assets");
118118
}
119119

120-
protected function bootCommands(): void
120+
protected function bootCommands()
121121
{
122122
if (empty($this->package->commands)) {
123123
return;
@@ -126,7 +126,7 @@ protected function bootCommands(): void
126126
$this->commands($this->package->commands);
127127
}
128128

129-
protected function bootConsoleCommands(): void
129+
protected function bootConsoleCommands()
130130
{
131131
if (empty($this->package->consoleCommands) || ! $this->app->runningInConsole()) {
132132
return;
@@ -135,7 +135,7 @@ protected function bootConsoleCommands(): void
135135
$this->commands($this->package->consoleCommands);
136136
}
137137

138-
protected function bootConfigs(): void
138+
protected function bootConfigs()
139139
{
140140
if ($this->app->runningInConsole()) {
141141
foreach ($this->package->configFileNames as $configFileName) {
@@ -147,7 +147,7 @@ protected function bootConfigs(): void
147147
}
148148
}
149149

150-
protected function bootInertia(): void
150+
protected function bootInertia()
151151
{
152152
if (! $this->package->hasInertiaComponents) {
153153
return;
@@ -166,7 +166,7 @@ protected function bootInertia(): void
166166
}
167167
}
168168

169-
protected function bootMigrations(): void
169+
protected function bootMigrations()
170170
{
171171
if ($this->package->discoversMigrations) {
172172
$this->discoverMigrations();
@@ -198,7 +198,7 @@ protected function bootMigrations(): void
198198
}
199199
}
200200

201-
protected function bootProviders(): void
201+
protected function bootProviders()
202202
{
203203
if (! $this->package->publishableProviderName || ! $this->app->runningInConsole()) {
204204
return;
@@ -211,7 +211,7 @@ protected function bootProviders(): void
211211
$this->publishes([$vendorProvider => $appProvider], "{$this->package->shortName()}-provider");
212212
}
213213

214-
protected function bootRoutes(): void
214+
protected function bootRoutes()
215215
{
216216
if (empty($this->package->routeFileNames)) {
217217
return;
@@ -222,7 +222,7 @@ protected function bootRoutes(): void
222222
}
223223
}
224224

225-
protected function bootTranslations(): void
225+
protected function bootTranslations()
226226
{
227227
if (! $this->package->hasTranslations) {
228228
return;
@@ -246,7 +246,7 @@ protected function bootTranslations(): void
246246
}
247247
}
248248

249-
protected function bootViews(): void
249+
protected function bootViews()
250250
{
251251
if (! $this->package->hasViews) {
252252
return;
@@ -263,7 +263,7 @@ protected function bootViews(): void
263263
}
264264
}
265265

266-
protected function bootViewComponents(): void
266+
protected function bootViewComponents()
267267
{
268268
if (empty($this->package->viewComponents)) {
269269
return;
@@ -281,7 +281,7 @@ protected function bootViewComponents(): void
281281
}
282282
}
283283

284-
protected function bootViewComposers(): void
284+
protected function bootViewComposers()
285285
{
286286
if (empty($this->package->viewComposers)) {
287287
return;
@@ -292,7 +292,7 @@ protected function bootViewComposers(): void
292292
}
293293
}
294294

295-
protected function bootViewSharedData(): void
295+
protected function bootViewSharedData()
296296
{
297297
if (empty($this->package->sharedViewData)) {
298298
return;
@@ -303,7 +303,7 @@ protected function bootViewSharedData(): void
303303
}
304304
}
305305

306-
protected function discoverMigrations(): void
306+
protected function discoverMigrations()
307307
{
308308
$now = Carbon::now();
309309
$migrationsPath = trim($this->package->migrationsPath, '/');

0 commit comments

Comments
 (0)