Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification Needed for ICP Input Settings in doICPVirtualRelativeWithInitial #2

Open
Hyunho111 opened this issue Jan 6, 2025 · 0 comments

Comments

@Hyunho111
Copy link

In the "doICPVirtualRelativeWithInitial" function (lines 603 to 607),
it seems unclear to me why the source and target inputs for ICP are set like this:

pcl::transformPointCloud(*cureKeyframeCloud, *transformed_curr, rotation_matrix);

// Align pointclouds
icp.setInputSource(cureKeyframeCloud);
icp.setInputTarget(transformed_curr);

In this scenario, ICP will likely return the value of the previous 'rotation_matrix' again without additional refinement.

Is there a specific reason for setting the inputs this way? I’d appreciate it if you could clarify this.

Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant