Skip to content

Commit e700326

Browse files
committed
Errors in pad mapping fixed
Not very well tested. (TX1 on Pad 10 does not work)
1 parent 55baa42 commit e700326

File tree

3 files changed

+30
-10
lines changed

3 files changed

+30
-10
lines changed

cores/arduino/am_sdk_ap3/mcu/apollo3/hal/am_hal_pin.h

+10-3
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@
4848
//
4949
//*****************************************************************************
5050

51+
//2020-03-25, Stephen Fordyce: Checked against Apollo3 datasheet DS-A3-0p9p1 Table 559 (p381) and fixed. To see fixes, search "Fixed" in the below.
52+
53+
5154
#ifndef AM_HAL_PIN_H
5255
#define AM_HAL_PIN_H
5356

@@ -70,6 +73,7 @@
7073
#define AM_HAL_PIN_1_MSPI5 (5)
7174
#define AM_HAL_PIN_1_NCE1 (7)
7275

76+
#define AM_HAL_PIN_2_UART1RX (0) //Fixed (added) SF 2020-03-25
7377
#define AM_HAL_PIN_2_SLMISO (1)
7478
#define AM_HAL_PIN_2_UART0RX (2)
7579
#define AM_HAL_PIN_2_GPIO (3)
@@ -85,11 +89,12 @@
8589
#define AM_HAL_PIN_3_I2S_WCLK (7)
8690
#define AM_HAL_PIN_3_PSOURCE (3)
8791

88-
#define AM_HAL_PIN_4_UART0CTS (0)
92+
#define AM_HAL_PIN_4_UART0CTS (0)
8993
#define AM_HAL_PIN_4_SLINT (1)
9094
#define AM_HAL_PIN_4_NCE4 (2)
9195
#define AM_HAL_PIN_4_GPIO (3)
92-
#define AM_HAL_PIN_4_UART0RX (5)
96+
//#define AM_HAL_PIN_4_UART0RX (5) //Fixed (removed) SF 2020-03-25
97+
#define AM_HAL_PIN_4_UART1RX (5) //Fixed (added) SF 2020-03-25
9398
#define AM_HAL_PIN_4_CTIM17 (6)
9499
#define AM_HAL_PIN_4_MSPI2 (7)
95100

@@ -129,6 +134,7 @@
129134
#define AM_HAL_PIN_9_SCCIO (4)
130135
#define AM_HAL_PIN_9_UART1RX (6)
131136

137+
#define AM_HAL_PIN_10_UART1TX (0) //Fixed (added) SF 2020-03-25
132138
#define AM_HAL_PIN_10_M1MOSI (1)
133139
#define AM_HAL_PIN_10_NCE10 (2)
134140
#define AM_HAL_PIN_10_GPIO (3)
@@ -437,7 +443,8 @@
437443
#define AM_HAL_PIN_44_CTIM20 (2)
438444
#define AM_HAL_PIN_44_GPIO (3)
439445
#define AM_HAL_PIN_44_M4MOSI (5)
440-
#define AM_HAL_PIN_44_M5nCE6 (6)
446+
#define AM_HAL_PIN_44_M5nCE6 (6) //Original, doesn't match Apollo 3 pin mapping table
447+
#define AM_HAL_PIN_44_UART0TX (6) //Fixed (added) SF 2020-03-25
441448

442449
#if defined (AM_PACKAGE_BGA)
443450
#define AM_HAL_PIN_45_UART1CTS (0)

cores/arduino/ard_sup/ap3_uart_types.h

+10-4
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,24 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2020
SOFTWARE.
2121
*/
2222

23+
//2020-03-25, Stephen Fordyce: Checked against Apollo3 datasheet DS-A3-0p9p1 Table 559 (p381) and fixed. To see fixes, search "Fixed" in the below.
24+
2325
#ifndef _AP3_UART_TYPES_H_
2426
#define _AP3_UART_TYPES_H_
2527

2628
#define AP3_UART_PIN_UNUSED 0xFF
2729

28-
#define AP3_UART0_NUM_TX_PADS 11
29-
#define AP3_UART0_NUM_RX_PADS 13
30+
//#define AP3_UART0_NUM_TX_PADS 11 //Fixed (removed) SF 2020-03-25
31+
#define AP3_UART0_NUM_TX_PADS 12 //Fixed (added) SF 2020-03-25
32+
//#define AP3_UART0_NUM_RX_PADS 13 //Fixed (removed) SF 2020-03-25
33+
#define AP3_UART0_NUM_RX_PADS 12 //Fixed (added) SF 2020-03-25
3034
#define AP3_UART0_NUM_RTS_PADS 8
3135
#define AP3_UART0_NUM_CTS_PADS 8
3236

33-
#define AP3_UART1_NUM_TX_PADS 11
34-
#define AP3_UART1_NUM_RX_PADS 11
37+
//#define AP3_UART1_NUM_TX_PADS 11 //Fixed (removed) SF 2020-03-25
38+
#define AP3_UART1_NUM_TX_PADS 12 //Fixed (added) SF 2020-03-25
39+
//#define AP3_UART1_NUM_RX_PADS 11 //Fixed (removed) SF 2020-03-25
40+
#define AP3_UART1_NUM_RX_PADS 13 //Fixed (added) SF 2020-03-25
3541
#define AP3_UART1_NUM_RTS_PADS 8
3642
#define AP3_UART1_NUM_CTS_PADS 8
3743

cores/arduino/ard_sup/uart/ap3_uart_structures.c

+10-3
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2020
SOFTWARE.
2121
*/
2222

23+
//2020-03-25, Stephen Fordyce: Checked against Apollo3 datasheet DS-A3-0p9p1 Table 559 (p381) and fixed. To see fixes, search "Fixed" in the below.
24+
2325
// #include "ap3_uart.h"
2426
#include "ap3_types.h"
2527
#include "ap3_uart_types.h"
@@ -35,12 +37,13 @@ const ap3_uart_pad_map_elem_t ap3_uart0_tx_map[AP3_UART0_NUM_TX_PADS] = {
3537
{.pad = 30, .funcsel = AM_HAL_PIN_30_UART0TX},
3638
{.pad = 39, .funcsel = AM_HAL_PIN_39_UART0TX},
3739
{.pad = 41, .funcsel = AM_HAL_PIN_41_UART0TX},
40+
{.pad = 44, .funcsel = AM_HAL_PIN_44_UART0TX}, //Fixed (added) SF 2020-03-25
3841
{.pad = 48, .funcsel = AM_HAL_PIN_48_UART0TX},
3942
};
4043

4144
const ap3_uart_pad_map_elem_t ap3_uart0_rx_map[AP3_UART0_NUM_RX_PADS] = {
4245
{.pad = 2, .funcsel = AM_HAL_PIN_2_UART0RX},
43-
{.pad = 4, .funcsel = AM_HAL_PIN_4_UART0RX},
46+
//{.pad = 4, .funcsel = AM_HAL_PIN_4_UART0RX}, //Fixed (removed) SF 2020-03-25
4447
{.pad = 11, .funcsel = AM_HAL_PIN_11_UART0RX},
4548
{.pad = 17, .funcsel = AM_HAL_PIN_17_UART0RX},
4649
{.pad = 21, .funcsel = AM_HAL_PIN_21_UART0RX},
@@ -72,12 +75,14 @@ const ap3_uart_pad_map_elem_t ap3_uart0_cts_map[AP3_UART0_NUM_CTS_PADS] = {
7275
{.pad = 24, .funcsel = AM_HAL_PIN_24_UART0CTS},
7376
{.pad = 29, .funcsel = AM_HAL_PIN_29_UART0CTS},
7477
{.pad = 33, .funcsel = AM_HAL_PIN_33_UART0CTS},
75-
{.pad = 26, .funcsel = AM_HAL_PIN_36_UART0CTS},
78+
//{.pad = 26, .funcsel = AM_HAL_PIN_36_UART0CTS}, //Fixed (removed) SF 2020-03-25
79+
{.pad = 36, .funcsel = AM_HAL_PIN_36_UART0CTS}, //Fixed (replaced with .pad=36 instead of =26) SF 2020-03-25
7680
{.pad = 38, .funcsel = AM_HAL_PIN_38_UART0CTS},
7781
};
7882

7983
const ap3_uart_pad_map_elem_t ap3_uart1_tx_map[AP3_UART1_NUM_TX_PADS] = {
8084
{.pad = 8, .funcsel = AM_HAL_PIN_8_UART1TX},
85+
{.pad = 10, .funcsel = AM_HAL_PIN_10_UART1TX}, //Fixed (added) SF 2020-03-25
8186
{.pad = 12, .funcsel = AM_HAL_PIN_12_UART1TX},
8287
{.pad = 14, .funcsel = AM_HAL_PIN_14_UART1TX},
8388
{.pad = 18, .funcsel = AM_HAL_PIN_18_UART1TX},
@@ -91,7 +96,9 @@ const ap3_uart_pad_map_elem_t ap3_uart1_tx_map[AP3_UART1_NUM_TX_PADS] = {
9196
};
9297

9398
const ap3_uart_pad_map_elem_t ap3_uart1_rx_map[AP3_UART1_NUM_RX_PADS] = {
94-
{.pad = 9, .funcsel = AM_HAL_PIN_9_UART1RX},
99+
{.pad = 2, .funcsel = AM_HAL_PIN_2_UART1RX}, //Fixed (added) SF 2020-03-25
100+
{.pad = 4, .funcsel = AM_HAL_PIN_4_UART1RX}, //Fixed (added) SF 2020-03-25
101+
{.pad = 9, .funcsel = AM_HAL_PIN_9_UART1RX},
95102
{.pad = 13, .funcsel = AM_HAL_PIN_13_UART1RX},
96103
{.pad = 15, .funcsel = AM_HAL_PIN_15_UART1RX},
97104
{.pad = 19, .funcsel = AM_HAL_PIN_19_UART1RX},

0 commit comments

Comments
 (0)