Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air alarm settings cease to control connected devices after a power cycle. #34852

Open
VerinSenpai opened this issue Feb 3, 2025 · 1 comment · May be fixed by #34887
Open

Air alarm settings cease to control connected devices after a power cycle. #34852

VerinSenpai opened this issue Feb 3, 2025 · 1 comment · May be fixed by #34887
Labels
S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.

Comments

@VerinSenpai
Copy link

VerinSenpai commented Feb 3, 2025

Description

As the title says. Air alarm settings need to be reselected upon an air alarm losing power. For example, if an air alarm is set to fill when power is lost, when power resumes none of the connected devices will behave as such, even though the alarm is still set to fill.

Reproduction
Set an air alarm to fill and observe that its connected vents and scrubbers are respecting the current selection.
Turn off the connected apc so the air alarm shuts down and reenable the apc.
Observe that the connected vents and scrubbers are no longer respected the fill selection.

Screenshots
https://github.com/user-attachments/assets/4db885ce-8df0-4ea4-98d3-9870d44197f8

Additional context
Don't mind the room pressure in that video. I wasn't conducing any nefarious experiments. Not at all.

Checked for an existing issue for this but didn't find one so heres hoping its not a dupe.

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Feb 3, 2025
@themias
Copy link
Contributor

themias commented Feb 3, 2025

I can replicate this. (The clearest way is to just set the Mode to 'None', and watch all the fans and filters turn back on when power is restored.)

The issue is that OnPowerChanged for the fans/filters directly sets enabled = true when the power is restored, which overrides whatever value it should be based on the Mode Preset.

@VerinSenpai VerinSenpai linked a pull request Feb 5, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants