Skip to content

Commit fce3456

Browse files
committed
Added some clarifying comments RE: regressions
[ci skip]
1 parent 710441a commit fce3456

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

CMakeLists.txt

+7-1
Original file line numberDiff line numberDiff line change
@@ -581,10 +581,10 @@ if(opencoarrays_aware_compiler)
581581

582582
# Regression tests based on reported issues
583583
if((gfortran_compiler AND (NOT CMAKE_Fortran_COMPILER_VERSION VERSION_LESS 7.0.0)) OR (CAF_RUN_DEVELOPER_TESTS OR $ENV{OPENCOARRAYS_DEVELOPER}))
584-
# GFortran PR 78505 only fixed on trunk/gcc 7, issue #243
585584
if( CMAKE_Fortran_COMPILER_VERSION VERSION_LESS 7.0.0 )
586585
message( WARNING "Developer tests requested and GFortran < 7: test source-alloc-no-sync may fail" )
587586
endif()
587+
# GFortran PR 78505 only fixed on trunk/gcc 7, issue #243
588588
add_mpi_test(source-alloc-no-sync 8 ${tests_root}/regression/reported/source-alloc-sync)
589589
endif()
590590

@@ -594,7 +594,13 @@ if(opencoarrays_aware_compiler)
594594
add_mpi_test(put-alloc-comp 2 ${tests_root}/regression/reported/issue-422-send)
595595
add_mpi_test(get-put-alloc-comp 3 ${tests_root}/regression/reported/issue-422-send-get)
596596
endif()
597+
598+
# Fixed GCC 7 regressions, should run on GCC 6 and 7
597599
add_mpi_test(event-post 3 ${tests_root}/regression/reported/event-post)
600+
601+
# These co_reduce (#172, fixed by PR #332, addl discussion in PR
602+
# #331) tests are for bugs not regressions. Should be fixed in all
603+
# version of GCC, I beleive
598604
add_mpi_test(co_reduce-factorial 4 ${tests_root}/regression/reported/co_reduce-factorial)
599605
add_mpi_test(co_reduce-factorial-int8 4 ${tests_root}/regression/reported/co_reduce-factorial-int8)
600606
add_mpi_test(co_reduce-factorial-int64 4 ${tests_root}/regression/reported/co_reduce-factorial-int64)

0 commit comments

Comments
 (0)