Skip to content

Commit 62bf1a8

Browse files
authored
Merge pull request #431 from sourceryinstitute/add-test-requirement
Edit PR template to bolster test requirements & tighten prose
2 parents 3a0fdce + 15a033f commit 62bf1a8

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+10-10
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,18 @@ This pull request (PR) is a:
3636

3737
### I certify that ###
3838

39-
- [ ] I have reviewed the [contributing guidelines] and followed the
40-
policies on:
41-
- Pull request (PR) naming to indicate work in progress (WIP),
42-
and to attach the PR to the appropriate bug report, or feature
43-
request [issue]
39+
- [ ] I reviewed and followed the [contributing guidelines], including
40+
- Increasing test coverage for all feature-addition PRs
41+
- Increasing test coverage for all bug-fix PRs for which there
42+
does not already exist a related test that failed before the PR
43+
- At least maintaining test coverage for all other PRs
44+
- Ensuring that all tests pass when run locally
45+
- Naming PR to indicate work in progress (WIP) and to attach the PR
46+
to the appropriate bug report or feature request [issue]
4447
- White space (no trailing white space or white space errors may
4548
be introduced)
4649
- Commenting code where it is non-obvious and non-trivial
47-
- Running tests locally, to ensure all of them pass
48-
- Maintaining or increasing test coverage
4950
- Logically atomic, self consistent and coherent commits
5051
- Commit message content
51-
- Waiting 24 hours before self-approving the pull request to
52-
give another OpenCoarrays developer a chance to review my
53-
proposed code
52+
- Waiting 24 hours before self-approving the PR to give another
53+
OpenCoarrays developer a chance to review my proposed code

0 commit comments

Comments
 (0)