File tree 1 file changed +10
-10
lines changed
1 file changed +10
-10
lines changed Original file line number Diff line number Diff line change @@ -36,18 +36,18 @@ This pull request (PR) is a:
36
36
37
37
### I certify that ###
38
38
39
- - [ ] I have reviewed the [ contributing guidelines] and followed the
40
- policies on:
41
- - Pull request (PR) naming to indicate work in progress (WIP),
42
- and to attach the PR to the appropriate bug report, or feature
43
- request [ issue]
39
+ - [ ] I reviewed and followed the [ contributing guidelines] , including
40
+ - Increasing test coverage for all feature-addition PRs
41
+ - Increasing test coverage for all bug-fix PRs for which there
42
+ does not already exist a related test that failed before the PR
43
+ - At least maintaining test coverage for all other PRs
44
+ - Ensuring that all tests pass when run locally
45
+ - Naming PR to indicate work in progress (WIP) and to attach the PR
46
+ to the appropriate bug report or feature request [ issue]
44
47
- White space (no trailing white space or white space errors may
45
48
be introduced)
46
49
- Commenting code where it is non-obvious and non-trivial
47
- - Running tests locally, to ensure all of them pass
48
- - Maintaining or increasing test coverage
49
50
- Logically atomic, self consistent and coherent commits
50
51
- Commit message content
51
- - Waiting 24 hours before self-approving the pull request to
52
- give another OpenCoarrays developer a chance to review my
53
- proposed code
52
+ - Waiting 24 hours before self-approving the PR to give another
53
+ OpenCoarrays developer a chance to review my proposed code
You can’t perform that action at this time.
0 commit comments