Skip to content

Continue, not return #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: base-sha/408bc2d84149673cdfcac27d9b2634389ec88145
Choose a base branch
from
Open

Continue, not return #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ttt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def main():
if not jsonlist:
print("Empty queue. Sleep 5 seconds and check again.")
time.sleep(5)
return
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (testing): Missing test for the change from return to continue.

The change from 'return' to 'continue' alters the flow of the program. It's crucial to add a test to verify that the system behaves as expected with this change, especially to ensure it does not enter an infinite loop or miss processing subsequent items in the queue.

Suggested change
return
# ttt.py
# Assuming this is part of a loop
if not jsonlist:
print("Empty queue. Sleep 5 seconds and check again.")
time.sleep(5)
continue

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment helpful?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment type correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment area correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment become an LLM test?

continue

for jsonfile in jsonlist:
# Ok, let's grab the first json and pull it out and then the matching wav file
Expand Down