Skip to content

Commit 51594dd

Browse files
committed
todos
1 parent 25ef210 commit 51594dd

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/commonMain/kotlin/spp.protocol/instrument/LiveSourceLocation.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package spp.protocol.instrument
1919

2020
import kotlinx.serialization.Serializable
21+
import spp.protocol.artifact.ArtifactLanguage
2122
import kotlin.jvm.JvmOverloads
2223

2324
/**
@@ -33,7 +34,8 @@ data class LiveSourceLocation @JvmOverloads constructor(
3334
val service: String? = null, //todo: can use Service
3435
val serviceInstance: String? = null, //todo: fully impl
3536
val commitId: String? = null, //todo: impl
36-
val fileChecksum: String? = null //todo: impl
37+
val fileChecksum: String? = null, //todo: impl
38+
//val language: ArtifactLanguage? = null, //todo: impl
3739
) : Comparable<LiveSourceLocation> {
3840

3941
override fun compareTo(other: LiveSourceLocation): Int {

src/commonMain/kotlin/spp.protocol/view/LiveViewSubscription.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ import spp.protocol.instrument.LiveSourceLocation
2929
*/
3030
@Serializable
3131
data class LiveViewSubscription(
32-
val subscriptionId: String? = null,
32+
val subscriptionId: String? = null, //todo: actual bottom
3333
val entityIds: List<String>,
3434
val artifactQualifiedName: ArtifactQualifiedName, //todo: remove, use artifactLocation
35-
val artifactLocation: LiveSourceLocation,
35+
val artifactLocation: LiveSourceLocation, //todo: bottom?
3636
val liveViewConfig: LiveViewConfig
3737
)

src/jvmMain/kotlin/spp/protocol/SourceServices.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ object SourceServices {
3737
var liveView: LiveViewService? = null
3838

3939
fun clearServices() {
40+
//todo: save services to project
4041
liveService = null
4142
liveInstrument = null
4243
liveView = null

0 commit comments

Comments
 (0)