Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Combobox: Bring in-house version of combobox  #43236

@vovakulikov

Description

@vovakulikov

Background

At the moment we do have wildcard abstractions for combobox UI pattern, but these abstraction are based on reach-ui combobox component Since reach-ui is no longer maintained reach/reach-ui#972 there is no a clear way to contribute to reach-ui in order to improve combobox or other parts of reach-ui package.

For example, for combobox we do have one issue that may block us from using combobox widely in our app reach/reach-ui#979. This is just one example of problems like this. We do have more of them but since Combobox UI doesn't expose enough API we can't fix them outside of Combobox UI.

In this issue we should fork or reimplement reach ui combobox in a way that it would be possible for us to support all missing features that Combobox at the moment doesn't have and can't have because of reach ui implementation.

Missing features

  • Persisting focus index over suggestion options
  • Custom keyboard navigation shortcuts
  • Custom open for extension highlight range logic
  • Support navigation over options with non unique values

/cc @sourcegraph/frontend-platform

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions