Skip to content

Commit 0bb47cd

Browse files
fix issue with array index out of bounds when accessing linkedConnections
1 parent f8ac8b6 commit 0bb47cd

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

packages/web/src/app/[domain]/components/errorNavIndicator.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export const ErrorNavIndicator = () => {
9595
<div className="flex flex-col gap-2">
9696
{repos
9797
.slice(0, 10)
98+
.filter(item => item.linkedConnections.length > 0) // edge case: don't show repos that are orphaned and awaiting gc.
9899
.map(repo => (
99100
// Link to the first connection for the repo
100101
<Link key={repo.repoId} href={`/${domain}/connections/${repo.linkedConnections[0].id}`} onClick={() => captureEvent('wa_error_nav_job_pressed', {})}>

packages/web/src/app/[domain]/components/progressNavIndicator.tsx

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,21 @@ export const ProgressNavIndicator = () => {
4848
The following repositories are currently being indexed:
4949
</p>
5050
<div className="flex flex-col gap-2 pl-4">
51-
{inProgressRepos.slice(0, 10).map(item => (
52-
// Link to the first connection for the repo
53-
<Link key={item.repoId} href={`/${domain}/connections/${item.linkedConnections[0].id}`} onClick={() => captureEvent('wa_progress_nav_job_pressed', {})}>
54-
<div className="flex items-center gap-2 px-3 py-2 bg-green-50 dark:bg-green-900/20
55-
rounded-md text-sm text-green-700 dark:text-green-300
56-
border border-green-200/50 dark:border-green-800/50
57-
hover:bg-green-100 dark:hover:bg-green-900/30 transition-colors">
58-
<span className="font-medium truncate">{item.repoName}</span>
59-
</div>
60-
</Link>
61-
))}
51+
{
52+
inProgressRepos.slice(0, 10)
53+
.filter(item => item.linkedConnections.length > 0) // edge case: don't show repos that are orphaned and awaiting gc.
54+
.map(item => (
55+
// Link to the first connection for the repo
56+
<Link key={item.repoId} href={`/${domain}/connections/${item.linkedConnections[0].id}`} onClick={() => captureEvent('wa_progress_nav_job_pressed', {})}>
57+
<div className="flex items-center gap-2 px-3 py-2 bg-green-50 dark:bg-green-900/20
58+
rounded-md text-sm text-green-700 dark:text-green-300
59+
border border-green-200/50 dark:border-green-800/50
60+
hover:bg-green-100 dark:hover:bg-green-900/30 transition-colors">
61+
<span className="font-medium truncate">{item.repoName}</span>
62+
</div>
63+
</Link>
64+
)
65+
)}
6266
{inProgressRepos.length > 10 && (
6367
<div className="text-sm text-green-600/90 dark:text-green-300/90 pl-3 pt-1">
6468
And {inProgressRepos.length - 10} more...

0 commit comments

Comments
 (0)