Skip to content

No longer compatible with libgpiod < 1.6.x #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alejandroclaro opened this issue Apr 5, 2024 · 4 comments
Closed

No longer compatible with libgpiod < 1.6.x #27

alejandroclaro opened this issue Apr 5, 2024 · 4 comments
Labels
bug Something isn't working gpiod-1.x all related to underlying libgpiod-1.x series help wanted Extra attention is needed

Comments

@alejandroclaro
Copy link

alejandroclaro commented Apr 5, 2024

The documentation states in the requirements that this should be compatible with libgpiod 1.x. However, since version 0.4 it's no longer compatible with libgpiod versions lower than 1.6.0

image

It would be nice its compatibility could be maintained since LTS versions of many distros, like Ubuntu 20.04, are still shipped with libgpiod 1.4.

If not possible, I recommend updating the documentation and clarify the minimum requirements.

@sombriks
Copy link
Owner

sombriks commented Apr 6, 2024

Hello @alejandroclaro , thank you for reporting this!
I think it is related to what @splitice was warning me about in #25 and indeed, i should add some kind of ifdef or something to make it possible to build node-libgpiod again under older versions -- as long as it is 1.x

@sombriks sombriks added bug Something isn't working gpiod-1.x all related to underlying libgpiod-1.x series labels Apr 6, 2024
@sombriks
Copy link
Owner

sombriks commented Apr 6, 2024

Hello @alejandroclaro when you have a chance, please check if it works again with libgpiod versions prior to 1.5 series.

@sombriks sombriks added the help wanted Extra attention is needed label Apr 6, 2024
@alejandroclaro
Copy link
Author

Thanks @sombriks !

I will test this today.

@alejandroclaro
Copy link
Author

@sombriks looks like everything is good now.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpiod-1.x all related to underlying libgpiod-1.x series help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants