Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Source via URL (Github, Soucify, etc) #7

Closed
0xCourtney opened this issue Oct 16, 2022 · 3 comments
Closed

Fetch Source via URL (Github, Soucify, etc) #7

0xCourtney opened this issue Oct 16, 2022 · 3 comments

Comments

@0xCourtney
Copy link
Contributor

reference: #6 (comment)

@ItsNickBarry
Copy link
Member

If bytecode is published to GitHub or similar, it can be added as an NPM dependency. Then, is there any reason to re-export it?

@0xCourtney 0xCourtney changed the title Fetch Bytecode via URL (Github, Soucify, etc) Fetch Source via URL (Github, Soucify, etc) Oct 16, 2022
@0xCourtney
Copy link
Contributor Author

If bytecode is published to GitHub or similar, it can be added as an NPM dependency. Then, is there any reason to re-export it?

I didn't really explain this but I was thinking that the plugin would fetch the source and then export the bytecode. Otherwise, I agree if the bytecode is already available somewhere it doesn't make sense to export it again.

@ItsNickBarry
Copy link
Member

This should be a feature of hardhat-dependency-compiler instead. If that plugin could download contract source code from a URL or by address from a blockchain explorer, then the compilation artifacts would be available not only to this plugin but also to hardhat-abi-exporter and hardhat-ethers (for deployment purposes).

Anyway, in the particular case of bytecode extraction, it's fairly simple to just use the eth_getCode RPC method.

Closing this in favor of this: ItsNickBarry/hardhat-dependency-compiler#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants