Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new NIRS analyzer FTIR6X #5296

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Adding new NIRS analyzer FTIR6X #5296

merged 2 commits into from
Feb 10, 2025

Conversation

chris263
Copy link
Contributor

@chris263 chris263 commented Feb 3, 2025

Description

Fixes #5278

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@afpowell afpowell requested review from isaak and afpowell February 3, 2025 16:08
isaak
isaak reviewed Feb 4, 2025
View reviewed changes
mason/tools/nirs/nirs_analysis_train_dialogs.mas Outdated
@@ -108,6 +108,7 @@
<option value="ASD Qualityspec">ASD Qualityspec</option>
<option value="ASD LabSpec">ASD LabSpec</option>
<option value="Specim FX17">Specim FX17</option>
<option values="FTIR6X">FT/IR-6X</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: 'values'

isaak
isaak reviewed Feb 4, 2025
View reviewed changes
mason/tools/high_dimensional_phenotypes/upload_high_dim_spreadsheet_dialogs.mas Outdated
@@ -130,6 +130,7 @@ $high_dimensional_phenotype_type => undef #either NIRS, Transcriptomics, Metabol
<option value="ASD Qualityspec">ASD Qualityspec</option>
<option value="ASD LabSpec">ASD LabSpec</option>
<option value="Specim FX17">Specim FX17</option>
<option values="FTIR6X">FT/IR-6X</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: 'values'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Isaak. It might be fixed now.

afpowell
afpowell approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@afpowell afpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasmueller lukasmueller merged commit 1d161a7 into master Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaak isaak isaak approved these changes

@afpowell afpowell afpowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new NIRS analyzer to Cassavabase
4 participants
@chris263 @isaak @afpowell @lukasmueller