Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accession Upload: add option to either append or replace synonyms #4858

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Accession Upload: add option to either append or replace synonyms #4858

merged 3 commits into from
Mar 25, 2024

Conversation

dwaring87
Copy link
Member

@dwaring87 dwaring87 commented Mar 18, 2024 •
edited
Loading

Description

This adds an option when uploading an accession template to either append or replace existing synonyms for existing accessions (the default is to append).

image

Fixes #4852

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

lukasmueller
lukasmueller approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller
Copy link
Member

Quick question, how are other attributes handled? Are they also replaced by default?

@lukasmueller lukasmueller merged commit ea16f6d into master Mar 25, 2024
1 check passed
@lukasmueller lukasmueller deleted the topic/accession_upload_synonyms branch March 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmueller lukasmueller lukasmueller approved these changes

@isaak isaak isaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Existing synonyms are removed when uploading existing accessions
3 participants
@dwaring87 @lukasmueller @isaak