Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Seedlot From Trial: add plot_name to name template #4848

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Create Seedlot From Trial: add plot_name to name template #4848

merged 1 commit into from
Mar 14, 2024

Conversation

dwaring87
Copy link
Member

Description

Adds {plot_name} as a possible variable for the seedlot name template

Fixes #4843

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@dwaring87 dwaring87 requested a review from chris263 March 11, 2024 14:54
chris263
chris263 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@chris263 chris263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukasmueller lukasmueller self-requested a review March 11, 2024 15:05
lukasmueller
lukasmueller approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit 390ba28 into master Mar 14, 2024
1 check passed
@lukasmueller lukasmueller deleted the topic/create_seedlots_trial_name branch March 14, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmueller lukasmueller lukasmueller approved these changes

@chris263 chris263 chris263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Seedlots from a trial with "plot_name"
3 participants
@dwaring87 @lukasmueller @chris263