add a script to download accessions given seedlot names. #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titima15
reviewed
Feb 21, 2024
bin/find_accessions_for_seedlots.pl
Outdated
|
|
||
| my $seedlot = CXGN::Stock::Seedlot->new( schema => $schema, seedlot_id => $seedlot_row->stock_id() ); | ||
|
|
||
| my $accession = $seedlot->accession(); |
There was a problem hiding this comment.
To make this script applicable to other databases, it might be good to check if the content is accession or cross by including $cross = $seedlot->cross();
Then indicate stock_type in the third column (seedlot name, content name, stock_type)
alockrow
approved these changes
Feb 22, 2024
titima15
reviewed
Feb 23, 2024
|
|
||
| # } | ||
| # $accession_name = join (", ", @accessions); | ||
|
|
There was a problem hiding this comment.
Do you still want to keep those commented out lines?
… but may be changed in the future.
titima15
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.