Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for gitbook manual to switch from merge to pull build #4801

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

darekbienkowski
Copy link
Contributor

@darekbienkowski darekbienkowski commented Jan 30, 2024

Description

New workflow:

-> If there are changes in documentation in a pull request, it triggers gitaction : Build documentation with R bookmark "test_static.yml"
It uses basic gitaction users to build static pages and add a commit with it to pull requests.
-> It will not trigger extra tests for the last commit - this means if there were code changes also - it only shows tests for the previous commits but not an automatic one
Once the documentation build is done - it can be merged with two reviews as any other pull request.
If there are changes in /docs folder, it triggers the GitHub pages deploy action in "static.yml" to deploy the content of /docs to GitHub pages.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@lukasmueller
Copy link
Member

This workflow is great

Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit 46e1e2f into master Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants